Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Student admin #1063
base: development
Are you sure you want to change the base?
Student admin #1063
Changes from 6 commits
064415d
378f998
7d19f29
bd4bf0b
8600142
148cbfb
86b43a3
ec5bf44
d81bc7c
1d505db
227866a
0bd4a63
2f401f8
7554fb3
2d08374
ffcf2c9
379e7ae
c9cbad0
8ff3aa9
293bd19
60c7431
ad4fca6
4b9c752
d1a2433
740f6b8
d5a2f74
a340704
bd4d1fd
c54bf3b
e50ca71
7d90425
cc64881
9bf62ff
5edb6cd
329d1d3
419d2a3
1e44a8c
807d724
4600233
86efbc6
1415951
44d1927
6381d44
f560f80
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the
isCeltsStudentStaff
check here, because all we care about is whether they are a program manager (and that will likely mean student staff is redundant)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. the
isCeltsStudentStaff
check is redundant withisProgramManager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And again here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is equivalent to
if g.current_user.isCeltsAdmin