Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds mobile sidebar #175

Merged
merged 2 commits into from
Sep 10, 2018
Merged

adds mobile sidebar #175

merged 2 commits into from
Sep 10, 2018

Conversation

alex-418
Copy link
Contributor

@alex-418 alex-418 commented Sep 7, 2018

mobile

@alex-418 alex-418 requested a review from bdolor September 7, 2018 20:30
@alex-418 alex-418 mentioned this pull request Sep 7, 2018
Closed
bdolor
bdolor reviewed Sep 10, 2018
View reviewed changes
Copy link
Contributor

@bdolor bdolor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to confirm that removing the sidebar menu on all pages except template landing pages is the desired behaviour. Seems counterintuitive.

@bdolor
Copy link
Contributor

bdolor commented Sep 10, 2018

@murphybarb @alex-418 - can you please confirm the above? Is it the intention to hide the sidebar menu (on mobile) for all pages, except the landing pages?

@alex-418
Copy link
Contributor Author

@bdolor @murphybarb My interpretation was that the mobile drop-down menu would replace the sidebar menu when on mobile. Should both exist on mobile?

@alex-418 alex-418 changed the title adds mobile sidebar to parent.blade adds mobile sidebar Sep 10, 2018
@bdolor bdolor merged commit 5b8db36 into dev Sep 10, 2018
@bdolor bdolor deleted the sidebar branch September 12, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdolor bdolor bdolor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alex-418 @bdolor