Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multisite support #1

Merged
merged 3 commits into from
Mar 13, 2017
Merged

add multisite support #1

merged 3 commits into from
Mar 13, 2017

Conversation

bdolor
Copy link

@bdolor bdolor commented Mar 13, 2017

  • adding namespace
  • multisite support
  • checkbox options replace text input
  • implementing coding standards
  • introduce class variables
  • sanitize input

@alexpflores - please review this Pull Request and merge if acceptable. It's a bit premature, but wanted to get the ball rolling.

@alex-418
Copy link

Looks great, love the checkboxes. Tested on my local, everything works fine, but what happens in the "Test Endpoints" section when you click one in a multisite setup?

Also, wondering if there's any value in identifying and then displaying what plugin registered the custom post type? Looking at this list, not sure where 2-3 of these are coming from. Not sure if there's an quick way of doing that.

local test

@bdolor
Copy link
Author

bdolor commented Mar 13, 2017

a9f268c will take care of test section on multisite. What ends up happening is that although the new route is registered for all sites in a multisite, the link is based off of the network url, which more often than not does not contain the custom post type. If this test section were to work, it could grab one of the sites on a multisite, and provide that as a test route, or it could just be removed. What do you think?

@alex-418
Copy link

I think that a quick note pointing them in the right direction on how to test their endpoints should suffice.

@alex-418 alex-418 merged commit b9c3f0b into master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants