Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS4 upgrade #92

Merged
merged 5 commits into from
Sep 20, 2018
Merged

BS4 upgrade #92

merged 5 commits into from
Sep 20, 2018

Conversation

alex-418
Copy link
Contributor

No description provided.

@alex-418
Copy link
Contributor Author

alex-418 commented Sep 20, 2018

@bdolor all new BS4 scripts are loading in the right order as per BS4 docs, but errors persist.

The Uncaught ReferenceError: Popper/Tooltip is not defined errors are coming from the following BS4 js files:

  • /bootstrap/js/dist/tooltip.js
  • /bootstrap/js/dist/popover.js

I've tried the following actions to no avail:

  • Using bootstrap.bundle.js (combines popper.js with bootstrap.js)
  • Separating bootstrap.js and bringing in popper.js separately (in the correct loading order)

The Uncaught TypeError: Cannot read property 'fn' of undefined error is coming from popover.js
So if you're also satisfied BS4 .js files are loaded correctly, and in the correct order... then I'd to pursue this and switch the jQuery version, as BS4 requires jQuery 3.x and WordPress core is at 1.11.4

@alex-418
Copy link
Contributor Author

alex-418 commented Sep 20, 2018

Tested updating core to jQuery 3.3.2, caused a lot of errors... mostly due to WP core jQuery scripts (and our own) using the formerly acceptable jQuery(document).ready(function()..... which was deprecated as of jQuery 1.8 and removed in jQuery 3.0 More info here

Copy link
Contributor

@bdolor bdolor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants