Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request instructions to readme #3

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

chelsabeth
Copy link
Collaborator

Add more detailed instructions to readme about how to make a pull request

Copy link
Owner

@BCtopics BCtopics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible job!

README.md Outdated
7. To confirm you have done these steps correctly when typing: ```git status``` it should tell you that you are on a specific branch.

### Create a new branch

It's best practice to work off a develop branch, not master.
It's best practice to work off a develop branch, not master.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this from master to main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this! This PR should reflect those changes.

Copy link
Owner

@BCtopics BCtopics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

@BCtopics BCtopics merged commit b05f8f2 into BCtopics:main Aug 1, 2022
@BCtopics BCtopics mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants