Mob drops not saved when set to decimals

[SkytraceXLSU]

Minecraft's Version

1.18.1

Plugin's Version

SuperiorSkyblock2-1.9.0-b557

Describe the bug

I have a problem for the /is admin setupgrade ( or other type upgrade is ) are reset at restart server ( we use custome menu for give cmd )

To Reproduce

with TrMenu do a custom menu and givi cmd
- 'CONSOLE: is admin setmobdrops %superior_island_name% 1.30'

Additional Information

No response

[OmerBenGera]

You said /is admin setupgrade resets, however you mentioned /is admin setmobdrops.
What does exactly reset? The upgrade level or the mob drops multiplier?

[SkytraceXLSU]

bonsoir seul le /is admin ne se reset pas toute autre commandes d'upgrade fonctionne correctement quand l'ont fait /is admin show mais quand le serveur restart a 5h du matin tout revient au niveau 1 par exemple : /is admin setmobdrops [is name] 1.30 et quand le serveur restart ca revient a 1.00 <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Garanti sans virus. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> Le dim. 27 mars 2022 à 20:28, Ome_R ***@***.***> a écrit :

…

You said /is admin setupgrade resets, however you mentioned /is admin setmobdrops. What does exactly reset? The upgrade level or the mob drops multiplier? — Reply to this email directly, view it on GitHub <#1021 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASZ7SH6YQLAWNDUBJ5QIMC3VCCSD5ANCNFSM5RYXTASQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[SkytraceXLSU]

good evening only the /is admin does not reset any other upgrade commands work correctly when /is admin show did but when the server restarts at 5am everything returns to level 1 for example : /is admin setmobdrops [is name] 1.30 and when the server restarts it returns to 1.00 Le dim. 27 mars 2022 à 20:44, Slytrace X ***@***.***> a écrit :

…

bonsoir seul le /is admin ne se reset pas toute autre commandes d'upgrade fonctionne correctement quand l'ont fait /is admin show mais quand le serveur restart a 5h du matin tout revient au niveau 1 par exemple : /is admin setmobdrops [is name] 1.30 et quand le serveur restart ca revient a 1.00 <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Garanti sans virus. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> <#m_4705671981073904328_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> Le dim. 27 mars 2022 à 20:28, Ome_R ***@***.***> a écrit : > You said /is admin setupgrade resets, however you mentioned /is admin > setmobdrops. > What does exactly reset? The upgrade level or the mob drops multiplier? > > — > Reply to this email directly, view it on GitHub > <#1021 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ASZ7SH6YQLAWNDUBJ5QIMC3VCCSD5ANCNFSM5RYXTASQ> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[OmerBenGera]

good evening only the /is admin does not reset any other upgrade commands work correctly when /is admin show did but when the server restarts at 5am everything returns to level 1 for example : /is admin setmobdrops [is name] 1.30 and when the server restarts it returns to 1.00 Le dim. 27 mars 2022 à 20:44, Slytrace X @.> a écrit :
…
bonsoir seul le /is admin ne se reset pas toute autre commandes d'upgrade fonctionne correctement quand l'ont fait /is admin show mais quand le serveur restart a 5h du matin tout revient au niveau 1 par exemple : /is admin setmobdrops [is name] 1.30 et quand le serveur restart ca revient a 1.00 https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Garanti sans virus. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#m_4705671981073904328_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> Le dim. 27 mars 2022 à 20:28, Ome_R @.> a écrit : > You said /is admin setupgrade resets, however you mentioned /is admin > setmobdrops. > What does exactly reset? The upgrade level or the mob drops multiplier? > > — > Reply to this email directly, view it on GitHub > <#1021 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ASZ7SH6YQLAWNDUBJ5QIMC3VCCSD5ANCNFSM5RYXTASQ > . > You are receiving this because you authored the thread.Message ID: > @.***> >

If you set the mob drops to 2, does it reset as well?

[SkytraceXLSU]

hi yes setmobsdrops at 2.00 stay after reset

[OmerBenGera]

hi yes setmobsdrops at 2.00 stay after reset

That is because you cant use decimals for mob-drops.
I will make sure to fix it in commands as well.

[SkytraceXLSU]

ahhh okay thx but was it possible to pass that in float ? in future update ?

[OmerBenGera]

ahhh okay thx but was it possible to pass that in float ? in future update ?

Probably not, as it doesn't make a lot of sense.
If you make the multiplier as 1.3, in most cases it will act the same as 1 as drop counts cannot be floats

[OmerBenGera]

I looked at the code again, and it seems like I did actually added support for decimals for mob drops, spawner rates and crop growth. I also tried setting my mob drops to 1.3 and it was saved after a restart.

What database are you using? SQLite or MySQL?

[Teyir]

Hey,

@SkytraceXLSU is my mate.

We use MySQL 5.7

Thank you

[OmerBenGera]

Check out latest dev build, let me know if it works for you.
You'll have to save the mob drops again for it to properly get saved.

[OmerBenGera]

Seems to be fixed, closing this
If it still occurs, lmk