Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASWM - Problem while loading island warps (during server startup) #1227

Closed
xSavior-of-God opened this issue Jul 2, 2022 · 5 comments
Closed

ASWM - Problem while loading island warps (during server startup) #1227

xSavior-of-God opened this issue Jul 2, 2022 · 5 comments
Assignees
@OmerBenGera
Labels
✔️ Confirmed Confirmed bugs that can be replicated

Comments

@xSavior-of-God
Copy link
Contributor

Minecraft's Version

1.16.2

Plugin's Version

Dev #706

Describe the bug

When loading islands, the server fails to generate island warps because the world is not loaded (via ASWM)

[22:32:52 INFO]: [SuperiorSkyblock2] Finished loading 2 players (Took 10ms)
[22:32:52 INFO]: [SuperiorSkyblock2] Starting to load islands...
[22:32:52 WARN]: java.lang.NullPointerException: location's world cannot be null.
[22:32:52 WARN]:        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:787)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.SIsland.createWarp(SIsland.java:2625)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.SIsland.lambda$loadFromCachedInfo$122(SIsland.java:3581)
[22:32:52 WARN]:        at java.util.ArrayList.forEach(ArrayList.java:1259)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.SIsland.loadFromCachedInfo(SIsland.java:3575)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.SIsland.fromDatabase(SIsland.java:312)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.factory.FactoriesManagerImpl.createIsland(FactoriesManagerImpl.java:119)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.GridManagerImpl.createIsland(GridManagerImpl.java:122)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.DataManager.lambda$loadIslands$2(DataManager.java:175)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.SQLDatabaseBridge.lambda$loadAllObjects$1(SQLDatabaseBridge.java:48)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.session.QueryResult.complete(QueryResult.java:34)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.session.impl.SQLiteSession.executeQuery(SQLiteSession.java:221)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.session.impl.SQLiteSession.select(SQLiteSession.java:168)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.SQLHelper.select(SQLHelper.java:85)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.SQLDatabaseBridge.loadAllObjects(SQLDatabaseBridge.java:45)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.DataManager.loadIslands(DataManager.java:174)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.DataManager.loadData(DataManager.java:69)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.SuperiorSkyblockPlugin.reloadPlugin(SuperiorSkyblockPlugin.java:517)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.SuperiorSkyblockPlugin.onEnable(SuperiorSkyblockPlugin.java:253)
[22:32:52 WARN]:        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263)
[22:32:52 WARN]:        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380)
[22:32:52 WARN]:        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483)
[22:32:52 WARN]:        at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:501)
[22:32:52 WARN]:        at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:415)
[22:32:52 WARN]:        at net.minecraft.server.v1_16_R3.MinecraftServer.loadWorld(MinecraftServer.java:593)
[22:32:52 WARN]:        at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:303)
[22:32:52 WARN]:        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1074)
[22:32:52 WARN]:        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:291)
[22:32:52 WARN]:        at java.lang.Thread.run(Thread.java:748)
[22:32:52 WARN]: java.lang.NullPointerException: location's world cannot be null.
[22:32:52 WARN]:        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:787)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.SIsland.createWarp(SIsland.java:2625)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.SIsland.lambda$loadFromCachedInfo$122(SIsland.java:3581)
[22:32:52 WARN]:        at java.util.ArrayList.forEach(ArrayList.java:1259)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.SIsland.loadFromCachedInfo(SIsland.java:3575)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.SIsland.fromDatabase(SIsland.java:312)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.factory.FactoriesManagerImpl.createIsland(FactoriesManagerImpl.java:119)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.island.GridManagerImpl.createIsland(GridManagerImpl.java:122)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.DataManager.lambda$loadIslands$2(DataManager.java:175)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.SQLDatabaseBridge.lambda$loadAllObjects$1(SQLDatabaseBridge.java:48)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.session.QueryResult.complete(QueryResult.java:34)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.session.impl.SQLiteSession.executeQuery(SQLiteSession.java:221)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.session.impl.SQLiteSession.select(SQLiteSession.java:168)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.SQLHelper.select(SQLHelper.java:85)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.sql.SQLDatabaseBridge.loadAllObjects(SQLDatabaseBridge.java:45)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.DataManager.loadIslands(DataManager.java:174)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.core.database.DataManager.loadData(DataManager.java:69)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.SuperiorSkyblockPlugin.reloadPlugin(SuperiorSkyblockPlugin.java:517)
[22:32:52 WARN]:        at com.bgsoftware.superiorskyblock.SuperiorSkyblockPlugin.onEnable(SuperiorSkyblockPlugin.java:253)
[22:32:52 WARN]:        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263)
[22:32:52 WARN]:        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380)
[22:32:52 WARN]:        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483)
[22:32:52 WARN]:        at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:501)
[22:32:52 WARN]:        at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:415)
[22:32:52 WARN]:        at net.minecraft.server.v1_16_R3.MinecraftServer.loadWorld(MinecraftServer.java:593)
[22:32:52 WARN]:        at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:303)
[22:32:52 WARN]:        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1074)
[22:32:52 WARN]:        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:291)
[22:32:52 WARN]:        at java.lang.Thread.run(Thread.java:748)
[22:32:52 INFO]: [SuperiorSkyblock2] Finished loading 0 islands (Took 54ms)

To Reproduce

  • Create an island
  • Set a warp
  • Quit and restart the server

When you join after restarting the server, the island instance is "null"

Additional Information

No response
@xSavior-of-God xSavior-of-God added the Pending Pending reports to be investigated label Jul 2, 2022
@OmerBenGera OmerBenGera added ✔️ Confirmed Confirmed bugs that can be replicated and removed Pending Pending reports to be investigated labels Jul 3, 2022
OmerBenGera added a commit that referenced this issue Jul 7, 2022
@OmerBenGera
Fixed the requirement of location worlds to be loaded in other places…
0390e8c 
… in the code (#1227)
@OmerBenGera
Copy link
Member

Fixed in latest dev build

@xSavior-of-God
Copy link
Contributor Author

Hi @OmerBenGera,
only today I had time to try the new version, but still the problem persists and in addition the server loads the island that has set a warp when it starts!

Version 1.11.0-b731

As soon as I entered, Superior did not recognize the islands,
the error is the following
image

image

@OmerBenGera OmerBenGera reopened this Jul 24, 2022
OmerBenGera added a commit that referenced this issue Jul 24, 2022
@OmerBenGera
Fixed cloning of LazyWorldLocation returns a regular Location instead…
e756657 
… of a LazyWorldLocation (#1227)
@OmerBenGera
Copy link
Member

Hi @OmerBenGera, only today I had time to try the new version, but still the problem persists and in addition the server loads the island that has set a warp when it starts!

Version 1.11.0-b731

As soon as I entered, Superior did not recognize the islands, the error is the following image

image

Fixed.

@xSavior-of-God
Copy link
Contributor Author

Hi, thanks for the fix...
Now the problem is solved,
but there is another one:

When starting, you force the load of all island worlds,
why, if I have more than 500 islands the server will never be able to start...
image

@OmerBenGera
Copy link
Member

Hi, thanks for the fix... Now the problem is solved, but there is another one:

When starting, you force the load of all island worlds, why, if I have more than 500 islands the server will never be able to start... image

This is no longer required, you don't have to load the worlds anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmerBenGera OmerBenGera

Labels
✔️ Confirmed Confirmed bugs that can be replicated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OmerBenGera @xSavior-of-God