Superior causing lags

[LuluxClient]

Minecraft's Version

1.18.2

Plugin's Version

1.11.1.766 dev build

Describe the bug

I've noticed that superiorSkyblock is the #1 plugin that consumes the most. After updating from dev buld 605 to 766 I've noticed that superior was taking way more than usual and I saw multiple things that were not in the timings before.

Also I was wondering what could I do to optimize it ?

To Reproduce

260 players on

Additional Information

If you need the spark link I can send it in dms

[OmerBenGera]

Nothing to do regarding this, this is your crops multiplier.
Also, it only takes around 3% which is a reasonable value, especially when you have 260 players on your server.

[LuluxClient]

Nothing to do regarding this, this is your crops multiplier. Also, it only takes around 3% which is a reasonable value, especially when you have 260 players on your server.

Well I've been doing multiple sparks and the "IslandFlagsListener$PaperListener.onEntitySpawn()" just appeared out of no where after updating. Why does it uses soo much. SuperiorSkyblock is 3-4 times more laggy than any other plugins I have atm. the second most laggiest plugin only takes 0.9%

What changed for that flag to consume sooo much and how can I resolve it.

[LuluxClient]

Before updating it consumes way less than now: (screenshot of spark before updating Superior)

[LuluxClient]

My spawners aren't stacked, they don't do any island levels, default mob spawning is disabled block stacking method is from Superior and not from a 3rd plugin

[OmerBenGera]

The entities that you see is the entity limiter - every mob that is added SSB counts and makes sure it doesnt exceed the limit. The crops you see in the spark is from the crop-growth multiplier and the spawners you see is due to the spawner-rates multiplier.

I will look into optimizing the spawners more, however for the rest nothing can be done regarding this - nothing was changed regarding of entities, and the lag from crops is because a lot of crop growth can cause lag.

[OmerBenGera]

Btw, 3% for a plugin in this scale is pretty good, especially with all the things it does and tracks.
Dont expect it to be at 0 because thats just not possible.

[OmerBenGera]

Also, please send the spark link here and do not take screenshots, as I would like to investigate the spark myself as well.

[LuluxClient]

Also, please send the spark link here and do not take screenshots, as I would like to investigate the spark myself as well.

https://spark.lucko.me/rNtkpnG96q
https://spark.lucko.me/6fdvQSLhva
https://spark.lucko.me/G1A6TiQIVE

[OmerBenGera]

About spawners -
it looks like lag comes from RoseStacker and not SuperiorSkyblock, as you can see here:
https://gyazo.com/6cd45a3299f47830833d589b0bc4cc11
https://gyazo.com/8f4a09561be1d8544db0ffef89e93935
https://gyazo.com/08d0bd9ddea861b013a7e494e090a75f

It shown under SSB as SSB registers a custom spawner tile that notifies the plugin when the spawner reaches it's final tick. However, it runs the original logic with is RoseStacker's in this case.

About the crops - I can clearly see an issue, and I will look into it.

About entity spawning - I see an issue with it as well, it struggles with checking for islands. I will look into it.

[LuluxClient]

About spawners - it looks like lag comes from RoseStacker and not SuperiorSkyblock, as you can see here: https://gyazo.com/6cd45a3299f47830833d589b0bc4cc11 https://gyazo.com/8f4a09561be1d8544db0ffef89e93935 https://gyazo.com/08d0bd9ddea861b013a7e494e090a75f

It shown under SSB as SSB registers a custom spawner tile that notifies the plugin when the spawner reaches it's final tick. However, it runs the original logic with is RoseStacker's in this case.

About the crops - I can clearly see an issue, and I will look into it.

About entity spawning - I see an issue with it as well, it struggles with checking for islands. I will look into it.

Ok thank you <3 ! This might be related to this issue because both of them happened after upgrade my superiorskyblock version #1323

[OmerBenGera]

I pushed a new update with some optimizations. Hopefully it will be better now

[LuluxClient]

After updating it looks a lot better

[OmerBenGera]

After updating it looks a lot better

Send a new spark profiler if possible :)

[LuluxClient]

After updating it looks a lot better

Send a new spark profiler if possible :)

[OmerBenGera]

After updating it looks a lot better

Send a new spark profiler if possible :)

Send me a link please

[LuluxClient]

After updating it looks a lot better

Send a new spark profiler if possible :)

Send me a link please

https://spark.lucko.me/PtnhaaRZcv

Also what's MobSpawnerAbstracter ? I don't have anything related to spawner value or things to accelerate it.

[OmerBenGera]

After updating it looks a lot better

Send a new spark profiler if possible :)

Send me a link please

https://spark.lucko.me/PtnhaaRZcv

Also what's MobSpawnerAbstracter ? I don't have anything related to spawner value or things to accelerate it.

This is for tracking spawners for the spawner rates upgrade.
However, the lag comes from RoseStacker and not SSB in that case.

[OmerBenGera]

I pushed a new update with another optimization for the spawn check.
Anything else I can help you with?

[LuluxClient]

Beh thanks other than that the only thing remaining is the /is recalc issue. Le ven. 2 sept. 2022 à 09:27, Ome_R ***@***.***> a écrit :

…

I pushed a new update with another optimization for the spawn check. Anything else I can help you with? — Reply to this email directly, view it on GitHub <#1317 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO5NOMGF6DAG2QPWC6UXIY3V4GT63ANCNFSM56QGLL4Q> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[OmerBenGera]

That's for the other report :)
Closing this for now