Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnchantingMissions: a several same items don't work #1784

Closed
Evalutik opened this issue Jul 7, 2023 · 4 comments
Closed

EnchantingMissions: a several same items don't work #1784

Evalutik opened this issue Jul 7, 2023 · 4 comments
Assignees
Labels
Pending Pending reports to be investigated

Comments

@Evalutik
Copy link

Evalutik commented Jul 7, 2023

Minecraft's Version

PurPur 1.19.3

Plugin's Version

SuperiorSkyblock2-2023.2-b45

Describe the bug

I'm trying to create a mission where, for example, you need to enchant 3 iron sets of armor (for example, each piece of armor for defense 4 durability 3)

required-enchants:
  '1':
    types:
      - 'IRON_HELMET'
    enchants:
      PROTECTION_ENVIRONMENTAL: 4
      DURABILITY: 3
      WATER_WORKER: 1
    **amount: 3**

But 1st:
As I already noticed (#1783) placeholders don't support quantity, they only say YES or NO.

2nd:
Despite the fact that amount: 3, placeholder changes to YES immediately after the first enchantment. One gets the impression that enchantments do not support the amount, but this is strange.

To Reproduce

Create mission of EnchantingMissions jar
set:

required-enchants:
  '1':
    types:
      - 'IRON_HELMET'
    enchants:
      PROTECTION_ENVIRONMENTAL: 4
      DURABILITY: 3
      WATER_WORKER: 1
    amount: 3

go to the server and try to enchant it.
you will complete the mission after 1st helmet.

Additional Information

my mission in .txt format:
enchanting2.txt

@Evalutik Evalutik added the Pending Pending reports to be investigated label Jul 7, 2023
@OmerBenGera
Copy link
Member

Enchanting missions only supports one time enchantments.
I am not sure why I did that like this tbh, I will look into changing it.

@OmerBenGera
Copy link
Member

I added support to the percentage_ and value_ placeholders as well within the EnchantsMissions.
Sorry for the long waiting time

@Evalutik
Copy link
Author

Evalutik commented Sep 1, 2023

value_

not working(
image
image
enchanting1.txt

@OmerBenGera
Copy link
Member

You should use {value_iron_helmet}, similar to the other missions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending Pending reports to be investigated
Projects
None yet
Development

No branches or pull requests

2 participants