Fixed a duplication glitch when other plugins try to remove items fro…

…m storage units (#109)
BG-Software-LLC · Aug 13, 2022 · 3581daf · 3581daf
1 parent 1db2b4a
commit 3581daf
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 12 deletions.
diff --git a/src/main/java/com/bgsoftware/wildchests/objects/chests/WChest.java b/src/main/java/com/bgsoftware/wildchests/objects/chests/WChest.java
@@ -160,7 +160,11 @@ public void removeItem(int amountToRemove, ItemStack itemStack) {
             int toRemove = Math.min(amountToRemove - itemsRemoved, ItemUtils.countItems(itemStack, page));
             ItemStack cloned = itemStack.clone();
             cloned.setAmount(toRemove);
-            page.removeItem(cloned);
+            ItemStack leftOver = page.removeItem(cloned).get(0);
+
+            if(leftOver != null)
+                toRemove -= leftOver.getAmount();
+
             itemsRemoved += toRemove;
         }
     }

diff --git a/src/main/java/com/bgsoftware/wildchests/objects/chests/WStorageChest.java b/src/main/java/com/bgsoftware/wildchests/objects/chests/WStorageChest.java
@@ -220,28 +220,42 @@ public void update() {
     public Map<Integer, ItemStack> addItems(ItemStack... itemStacks) {
         Map<Integer, ItemStack> additionalItems = new HashMap<>();
 
-        ItemStack storageItem = getItemStack();
+        BigInteger amountToAdd = BigInteger.ZERO;
 
         for (int i = 0; i < itemStacks.length; i++) {
-            ItemStack itemStack = itemStacks[i];
-
-            if (storageItem.getType() == Material.AIR) {
-                setItemStack(itemStack);
-                storageItem = itemStack.clone();
-            }
+            if (itemStacks[i] == null)
+                continue;
 
-            if (storageItem.isSimilar(itemStack)) {
-                setAmount(getAmount().add(BigInteger.valueOf(itemStack.getAmount())));
+            if (!canPlaceItemThroughFace(itemStacks[i])) {
+                additionalItems.put(i, itemStacks[i]);
             } else {
-                additionalItems.put(i, itemStack);
+                if (getItemStack().getType() == Material.AIR)
+                    setItemStack(itemStacks[i]);
+
+                amountToAdd = amountToAdd.add(BigInteger.valueOf(itemStacks[i].getAmount()));
             }
         }
 
-        updateInventory(getPage(0));
+        if (amountToAdd.compareTo(getAmount()) != 0) {
+            setAmount(getAmount().add(amountToAdd));
+            updateInventory(getPage(0));
+        }
 
         return additionalItems;
     }
 
+    @Override
+    public void removeItem(int amountToRemove, ItemStack itemStack) {
+        ItemStack storageItem = getItemStack();
+
+        if (storageItem.getType() == Material.AIR || !storageItem.isSimilar(itemStack))
+            return; // Storage unit is empty
+
+        setAmount(getAmount().subtract(BigInteger.valueOf(amountToRemove)));
+
+        updateInventory(getPage(0));
+    }
+
     @Override
     public boolean onBreak(BlockBreakEvent event) {
         broken = true;