Physical_oM: Formalise Density management

[IsakNaslundBh]

Issues addressed by this PR

Closes #1442

Adding IDesityProvider interface and making current materials in Env and Str implement it

Note there is also the LCADensity fragment in LCA_oM. AS it currently does not implement IMaterialProperty I left it out for now. One to potentially be rejigged and refactored. @michaelhoehn

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Eg7Y5NfGykJKr5Bc1wfki6ABOXhTCqmW-pr3oNrYvFzKYA?e=tJxtni

Changelog

Additional comments

This should make 0 difference for the Environmental and structural materials in terms of their current functionality on main when used in discipline workflows. What this will enable is to in a more formalised why be able to extract and set density to a physical material.

[IsakNaslundBh]

Thanks for comments @FraserGreenroyd , all good and Valid.

Should have made this Draft when raising, mistake by myself, so potential kind of major changes upcoming (and might even delete the objects you have commented on).

Have turned this to draft now, but if object are kept, I will make sure to apply fixes related to you comments! :)

[FraserGreenroyd]

@IsakNaslundBh ah, no worries! Ignore what's not relevant, lemme know when it's ready for review again and I can take another look if you need/want me to 😄

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 11 requests in the queue ahead of you.

[bhombot-ci]

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

[IsakNaslundBh]

@BHoMBot check compliance
@BHoMBot check installer

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check installer

[bhombot-ci]

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

[IsakNaslundBh]

@BHoMBot check versioning

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check versioning

[IsakNaslundBh]

@BHoMBot check core
@BHoMBot check serialisation

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check core
• check serialisation

There are 8 requests in the queue ahead of you.

[bhombot-ci]

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

[al-fisher]

Thanks @IsakNaslundBh for this.
Looking good now. Happy with code review now and further future compliance issues raised.

(I also raised #1445 regarding possible review and improvement of name given to IDensityProvider - saying that, I could not immediately think of much better - so perhaps after discussion we simply close that issue!! 😄 )

However importantly testing creation and manipulation of Physical Materials and their new Density Property is working as expected in my testing this end.

I am still having issues with the provided test scripts - which is weird - so will not approve and merge right now.

[al-fisher]

@IsakNaslundBh - grab a quick chat tomorrow morning on the test scripts to see what might be going on there!

[al-fisher]

Happy to approve this now based on my previous functionality review and comments above
Issue with test scripts was resolved (un related issue to do with logs)

Have adressed comments made in review, and getting offline approval from @fraser to dismiss this review on approval.

[al-fisher]

@BHoMBot check ready-to-merge

[bhombot-ci]

@al-fisher to confirm, the following actions are now queued:

• check ready-to-merge