Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do geometries need to have another way of assigning IDs/URIs? Currently two identical points are recognized as the same one #40

Closed
DiellzaElshani opened this issue Jul 5, 2022 · 2 comments
Labels
type:question Ask for further details or start conversation

Comments

@DiellzaElshani
Copy link
Collaborator

DiellzaElshani commented Jul 5, 2022

Currently geometries use the HashCode to get an URI in the TLL format. However, when two identical points are input to the graph, they are not recognized as two points, but as one. I understand that BHoM does not assign GUID to geometries, to handle complex geometries more efficiently. But this might bring some problems in the RDF graph representation.

image

Steps to reproduce:

I am not sure if that is a problem, maybe not. However, if yes:
I suggest having another way to generate the URI (rather than the hashcode). An way to approach this can be to: whenever we use geometry as input, always use a custom object where we also add a label (user input ID, or something similar); from where we generate a static, unique GUID (or we use the Custom Objects ID to refer to the geometry).

image

Expected behaviour:

Test file(s):

@DiellzaElshani DiellzaElshani added type:bug Error or unexpected behaviour priority:high High impact, high user value, driven by live project needs type:question Ask for further details or start conversation labels Jul 5, 2022
@alelom
Copy link
Member

alelom commented Jul 6, 2022

Please see my reply #41 (comment).

@DiellzaElshani
Copy link
Collaborator Author

DiellzaElshani commented Jul 12, 2022

As suggested on your #41 (comment), we should switch to using the static hash.

@alelom alelom removed priority:high High impact, high user value, driven by live project needs type:bug Error or unexpected behaviour labels Jul 12, 2022
@alelom alelom closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Ask for further details or start conversation
Projects
None yet
Development

No branches or pull requests

2 participants