Recommendations for axios retry condition #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some pretty big changes to your #22, take a look here:
retryCondition
due to how Nuxt module options get serialized. This also lets us mixin the retry functionality into instances of$axios
created by$axios.create()
One thing I discovered in doing this was that the interceptors that are created by axios retry are not propagated when new Axios clients are created, like we do in
@cloak-app/craft
. So after this merged, we'll have to add some code to that package to re-apply retrying to that packages axios instances 😓 . I made BKWLD/cloak-craft#14 for this.