Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sanity crop handling #24

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Fix Sanity crop handling #24

merged 3 commits into from
Aug 21, 2023

Conversation

weotch
Copy link
Member

@weotch weotch commented Aug 21, 2023

No description provided.

Sanity’s asset-utils were not able to prase a URL with rect instrcutions back to hotspot and crop
@cypress
Copy link

cypress bot commented Aug 21, 2023

Passing run #71 ↗︎

0 8 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Make a unique imageLoader for each image
Project: react-visual Commit: e34521af43
Status: Passed Duration: 00:06 💡
Started: Aug 21, 2023 10:49 PM Ended: Aug 21, 2023 10:49 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@weotch weotch merged commit 3970024 into main Aug 21, 2023
3 checks passed
@weotch weotch deleted the fix-sanity-crop-handling branch August 21, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant