Add option to render the carousel track as an unordered list #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
weotch
requested changes
Mar 1, 2023
| @@ -144,7 +147,7 @@ export default | |||
|
|
|||
| # Render the track and slotted slides | |||
| render: (create) -> | |||
| create 'div', | |||
| create @trackHTMLElement, | |||
There was a problem hiding this comment.
We could possibly make this not require a new prop by checking if the firs slide returned by makeSlides() has an element of li. Can you console.log it and see if has a type or element property or something like that so we can try and auto-determine this?
There was a problem hiding this comment.
just updated the pr with the requested change
weotch
requested changes
Mar 20, 2023
weotch
approved these changes
Mar 20, 2023
Little syntax tweaks
|
@lemoswilson I tagged this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change requested as part of the HFO ADA audit made by Level Access.
On the page https://www.happyfamilyorganics.com/our-story/ we have a button carousel that is used to navigate between the tabs of a block, and Level Access wrote the following about it:
_The below-mentioned textual links below "Take a Journey Through Our Story" heading text visually appear as list items but are not marked using HTML list markup. When links are properly grouped, it facilitates labeling the group, skipping past the group, and helps to divide large blocks of information into more manageable components.
Following instances are affected:
[User Impact]
Screen reader users will benefit if the content has been structured using list markup._
This small change should provide a better user experience for screen reader users.