Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Audio Support #26

Merged
merged 3 commits into from Jan 11, 2015
Merged

Added Audio Support #26

merged 3 commits into from Jan 11, 2015

Conversation

licson
Copy link
Contributor

@licson licson commented Jan 10, 2015

I have added positional audio support to HexGL which uses Web Audio API and it'll fallback to HTML5 audio if needed (IE11).

@BKcore
Copy link
Owner

BKcore commented Jan 10, 2015

Thank you for the contribution!

Quick questions:

  • Can you include a license file for the audio files (and make sure they're free to use)?
  • The boost sounds after the first boost don't seem to work for me. Can you check that out?

@licson
Copy link
Contributor Author

licson commented Jan 11, 2015

License file included!

I've checked the boosting sound problem and now it should be fixed. Also, the audio engine is improved to give better audio positioning. Works good in latest Chrome and IE11.

@BKcore
Copy link
Owner

BKcore commented Jan 11, 2015

Cool, thanks!
Merging.

BKcore pushed a commit that referenced this pull request Jan 11, 2015
@BKcore BKcore merged commit 3495ddf into BKcore:master Jan 11, 2015
DouglasSherk pushed a commit to fxos/HexGL that referenced this pull request May 20, 2015
DouglasSherk pushed a commit to fxos/HexGL that referenced this pull request May 20, 2015
DouglasSherk pushed a commit to fxos/HexGL that referenced this pull request May 21, 2015
DouglasSherk pushed a commit to fxos/HexGL that referenced this pull request May 21, 2015
DouglasSherk pushed a commit to fxos/HexGL that referenced this pull request May 21, 2015
DouglasSherk pushed a commit to fxos/HexGL that referenced this pull request May 21, 2015
DouglasSherk pushed a commit to fxos/HexGL that referenced this pull request May 25, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request May 25, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request May 25, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request May 25, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request May 29, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request May 29, 2015
DouglasSherk pushed a commit to fxos/HexGL that referenced this pull request Jun 4, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 5, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 9, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 11, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 12, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 12, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 12, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 12, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 16, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jun 18, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jul 8, 2015
spark-bot pushed a commit to fxos/HexGL that referenced this pull request Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants