This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
Core: Fix - Keypath lookup #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjmconie
commented
Sep 16, 2019
cjmconie
commented
- Consolidate key path lookup logic.
- Account for nested string key paths.
cjmconie
force-pushed
the
core/fix/keypath
branch
from
2a361d7
to
70480fe
Compare
MalcolmnDEV
approved these changes
Sep 16, 2019
|
|
||
| extension String { | ||
|
|
||
| /// Returns an array of string split using the specified regular expresion. |
There was a problem hiding this comment.
Returns an array of strings -> makes the sentence sound better
BlockV/Core/Helpers/KeyPath.swift
Outdated
| private(set) var segments: [String] | ||
|
|
||
| typealias Separator = (String) -> [String] | ||
| // default separator uses standard period separation |
There was a problem hiding this comment.
shouldn't this be a Capital, its not an inline comment
cjmconie
added a commit
that referenced
this pull request
Dec 13, 2019
* Add nonpushNotification property * Add reason associated value * Fix crash were selected face view was nil Refactor VVLC into simpler functions * Fix safe area content behaviour * Improve page fetching * Add region error Remove unnecessary code Lint * Add io serial queue to perform disk io tasks * Re-connect to the socket on session launch * Add write ping * Create a BoundedView to inform its subclass once the bounds have been set Update the cacheKey to include the target size * Update cacheKey to include the target size * Add source key pair to better inform the listen of the source of the update * Fix transformation and encoding issue preventing ui.qr.scan in v1 of the bridge protocol from working * Add pixelSize property to UIImageView * Make FaceView a subclass of BoundedView * Auto reconnect the socket after an unintentional disconnect * Add delay options * Add support for bridge 2.1 core.user.current.get * Explicitly set sharedUrlCache capacities * Add 1604 error message * Update error bindings * Pin GenericJSON to 2.0 * Add root props lookup for cloning_score and num_direct_clones * Update AddressAccountModel.swift * Add unit tests for address accounts model * Add sync * Add WSMapEvent * Observer map event updates * Add map event unit test * Remove example payload * Add resource downloader * Add data downloader * Extensions to compute allocated size of directory * Add recommended cache directory property * Improve unit tests * Relax lint rules * Add when_added property * Core: Fix - Region events (#265) * Emit changes for affected vatom and previous and new parent * Broadcast did update events * Fix will add and did add events * Parse action name * Core: Fix - Single vatom (#267) * Add getVatom request * Add get vatom payload to api layer * Add chucked method to array * Add convenience helpers * Assert when backend fetch limit is exceeded Fix parameter * Load inventory using vatom sync numbers * Make sync optional * Improve consistency of socket logging * Convert print statements to os_log * Move bounded view to new file * Core: Feature - OAuth flow (#275) * Update auth server to extract flow query param * Core: Fix - Image downloader (#277) * Update Nuke to version 8.0 * Catch URLEncodingError case * Expose debug function to clear auth credentials * Fix reconnect scheduler to use delay option * Disconnect on background and reconnect on foreground * Leverage vatom's valueForKeyPath(:) method * Update BLOCKv+VatomRequest.swift * Core: Fix - Keypath lookup (#287) * Add regular expression split extension * Adjust keypath to use a separator closure * Update ImageDownloader.swift * Update key path to handle nested strings * Fetch current user as part of the OAuth flow * Update ImageDownloader.swift * Hide progress label when width is below 100 pts * Expose blockv encoder and decoder * Fix logic to detect token expiration * Revert "Core: Fix - OAuth handler" * Retry timed-out requests once * Core: Feature - Request redemption (#297) * Add endpoint constructor for redemption request * Add merchant redeem request * Passthrough bridge error * Fix ordering of encoding params * Expose face error enum * Add FacePresenter as a primitive interface used by types seeking to present a face * Add face trigger rules * Re-add region update * Emit update * Update reset to clear regions and url cache * Add preemptive events * Distribute drop and pickup preemptive updates to all regions * Update dependencies * Update README * Update json to include when_added * Conform to error spec 1.0.0 * Update folder structure * Add split and combine actions with preemptive injection * Add child listing convenience functions to data pool
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.