-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POLIO-1616 Chronogram: create a permission with less rights #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemar
force-pushed
the
POLIO-1616-chronogram-perms
branch
from
August 5, 2024 13:38
5217e21
to
ba32f10
Compare
kemar
force-pushed
the
POLIO-1616-chronogram-perms
branch
from
August 5, 2024 14:05
ba32f10
to
a7f01a3
Compare
…OGRAM` and `POLIO_CHRONOGRAM_RESTRICTED_WRITE` perms
hakifran
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some stuff to fix but in general everything looks good to me
...s/polio/js/src/domains/Chronogram/ChronogramDetails/Modals/ChronogramTaskCreateEditModal.tsx
Outdated
Show resolved
Hide resolved
...s/polio/js/src/domains/Chronogram/ChronogramDetails/Modals/ChronogramTaskCreateEditModal.tsx
Outdated
Show resolved
Hide resolved
.../polio/js/src/domains/Chronogram/ChronogramDetails/Table/useChronogramDetailsTableColumn.tsx
Outdated
Show resolved
Hide resolved
plugins/polio/js/src/domains/Chronogram/Chronogram/Table/useChronogramTableColumns.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: hakifran <fhakizimana@bluesquarehub.com>
…for the permission
hakifran
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kemar
added
release
Should be released in production at next deploy
Released
and removed
release
Should be released in production at next deploy
labels
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POLIO-1616 Chronogram: create a permission with less rights.
Related JIRA tickets : POLIO-1616
Changes
Users with restricted rights should not be able to:
They should be able to:
Print screen
New perm:
Differences between perms: