-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3206-IA-3207: Move and add projects columns and filters on User and OrgUnit pages #1543
Merged
hakifran
merged 7 commits into
main
from
IA-3206-IA-3207-projects-columns-filter-User-And-OrgUnit-Pages
Aug 12, 2024
Merged
IA-3206-IA-3207: Move and add projects columns and filters on User and OrgUnit pages #1543
hakifran
merged 7 commits into
main
from
IA-3206-IA-3207-projects-columns-filter-User-And-OrgUnit-Pages
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-And-OrgUnit-Pages
kemar
reviewed
Aug 9, 2024
kemar
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a way to fix a N+1 problem in backend queries here #1547
Also Cypress tests are failing, can you please fix them?
Fix N+1 in org unit API for projects
kemar
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hakifran
deleted the
IA-3206-IA-3207-projects-columns-filter-User-And-OrgUnit-Pages
branch
August 12, 2024 09:36
kemar
added
Released
and removed
release
Should be released in production at next deploy
labels
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain what problem this PR is resolving
Related JIRA tickets : IA-3206 IA-3207
Self proofreading checklist
Doc
Changes
How to test
Print screen / video
Org unit page
User page
Notes
Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here