Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3206-IA-3207: Move and add projects columns and filters on User and OrgUnit pages #1543

Merged

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented Aug 8, 2024

Explain what problem this PR is resolving

  • Move and add projects columns and filters on User and OrgUnit pages
  • Remove some columns and move others on User and OrgUnit Pages
    Related JIRA tickets : IA-3206 IA-3207

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

  • Tell us where the doc can be found (docs folder, wiki, in the code...)

Changes

  • Move projects filter on both user and org unit page
  • Removed groups column from org unit page
  • Move created column on org unit page

How to test

  • Go on User page and check if the change are same as on the mockup
  • Go on org unit page and check also if change are same as on the mockup

Print screen / video

Org unit page

Screenshot-from-2024-08-08-16-02-01

User page

Screenshot-from-2024-08-08-16-02-12

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here

@hakifran hakifran requested a review from kemar August 8, 2024 14:06
@hakifran
Copy link
Contributor Author

hakifran commented Aug 8, 2024

@cypress

Copy link

github-actions bot commented Aug 8, 2024

@hakifran
Copy link
Contributor Author

hakifran commented Aug 9, 2024

@cypress

Copy link

github-actions bot commented Aug 9, 2024

Copy link
Member

@kemar kemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a way to fix a N+1 problem in backend queries here #1547

Also Cypress tests are failing, can you please fix them?

iaso/tests/api/test_orgunits.py Outdated Show resolved Hide resolved
Fix N+1 in org unit API for projects
@kemar kemar added the release Should be released in production at next deploy label Aug 12, 2024
Copy link
Member

@kemar kemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hakifran hakifran merged commit dcf228b into main Aug 12, 2024
5 of 7 checks passed
@hakifran hakifran deleted the IA-3206-IA-3207-projects-columns-filter-User-And-OrgUnit-Pages branch August 12, 2024 09:36
@kemar kemar added Released and removed release Should be released in production at next deploy labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants