Skip to content

Commit

Permalink
Merge pull request #5074 from BOINC/dpa_url2
Browse files Browse the repository at this point in the history
client: don't print a (confusing) warning if we're using an https:// URL
  • Loading branch information
AenBleidd committed Jan 25, 2023
2 parents ba026ec + f9196f4 commit db0419d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions client/cs_scheduler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -594,10 +594,9 @@ int CLIENT_STATE::handle_scheduler_reply(

// compare our URL for this project with the one returned in the reply
// (which comes from the project's config.xml).
// - if http -> https transition, make the change
// - if http -> https transition, use the https: one from now on
// - if https -> http transition, keep using the https: one
// - otherwise notify the user.
// This means that if a project changes its master URL,
// its users have to detach/reattach.
//
if (strlen(sr.master_url)) {
canonicalize_master_url(sr.master_url, sizeof(sr.master_url));
Expand All @@ -612,6 +611,9 @@ int CLIENT_STATE::handle_scheduler_reply(
msg_printf(project, MSG_INFO,
"Project URL changed from http:// to https://"
);
} else if (is_https_transition(reply_url.c_str(), current_url.c_str())) {
// project is advertising http://, but https:// works.
// keep using https://
} else {
msg_printf(project, MSG_USER_ALERT,
_("This project seems to have changed its URL. When convenient, remove the project, then add %s"),
Expand Down

0 comments on commit db0419d

Please sign in to comment.