Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Use ATI GPU" on project preferences to "Use AMD GPU" #2063

Closed
Ageless93 opened this issue Aug 23, 2017 · 7 comments
Closed

Change "Use ATI GPU" on project preferences to "Use AMD GPU" #2063

Ageless93 opened this issue Aug 23, 2017 · 7 comments

Comments

@Ageless93
Copy link
Contributor

In 2006 AMD bought ATI.
Since 2010, AMD has ceased using ATI as a brand.
So can we please follow and change the "Use ATI GPU" in the project preferences to "Use AMD GPU"?

@SebastianoPistore
Copy link

It's TRUE! I had never thought about it, but it did not matter that everyone knows it.

Radeon/FirePro = ATI/AMD

A user who does not know what to select can look at the box on his graphics card and do not find the word "ATI", but only "AMD".

@Ageless93 Ageless93 added this to Backlog in Website and Drupal via automation Nov 11, 2017
@AenBleidd AenBleidd added this to the Server milestone Oct 17, 2018
@AenBleidd AenBleidd added the Newbie Suitable for a new contributor label Oct 17, 2018
@AenBleidd
Copy link
Member

@davidpanderson, I believe it is a ticket that could be fixed very easily, am I right?

@homersimpsons
Copy link

Hi, should all locale files be updated too, or will this be done by transifex ?
Should every ATI string be replaced by AMD or just "Use ATI GPU" (there are some like "Faking an ATI GPU", "No ATI library found.", "CAL: ATI GPU %d: %s") ?
Should code occurrences be replaced, as for example have_ati ?

@ChristianBeer
Copy link
Member

The locale files are updated separately. Most important are the user facing strings (text occurring inside _() or tra() functions). Please don't change code occurrences.

@JuhaSointusalo
Copy link
Contributor

"ATI" was changed to "AMD" in task list and details and in ops section in #2844.

"ATI" is practically ungreppable. There's way too many false hits so it's not possible to tell if there are more changes needed. So I'm leaving this open for now. If some "ATI" strings remained future reports must point to the exact location of the string.

@JuhaSointusalo
Copy link
Contributor

#2847 does the change on Drupal website for project preferences and task list.

@AenBleidd
Copy link
Member

Looks like it is fixed so I'm closing it now

Website and Drupal automation moved this from Backlog to Done May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants