Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: change "ATI GPU" to "AMD GPU" in host app details #3016

Merged
merged 1 commit into from
Apr 11, 2019
Merged

web: change "ATI GPU" to "AMD GPU" in host app details #3016

merged 1 commit into from
Apr 11, 2019

Conversation

JuhaSointusalo
Copy link
Contributor

See #2063

@davidpanderson
Copy link
Contributor

We can remove the tra() around these

@JuhaSointusalo
Copy link
Contributor Author

I don't mind that these strings are translatable. It lets translator translate 'GPU' or change word order if they see it necessary. A few translators have actually done just that:

html/languages/translations/eu.po:msgid "Use ATI GPU"
html/languages/translations/eu.po:msgstr "Erabili ATI GPUa"
html/languages/translations/eu.po:msgid "ATI GPU"
html/languages/translations/eu.po:msgstr "ATI GPUa"

html/languages/translations/pt_BR.po:msgid "Use ATI GPU"
html/languages/translations/pt_BR.po:msgstr "Usar GPU ATI"
html/languages/translations/pt_BR.po:msgid "ATI GPU"
html/languages/translations/pt_BR.po:msgstr "GPU ATI"

html/languages/translations/pt_PT.po:msgid "Use ATI GPU"
html/languages/translations/pt_PT.po:msgstr "Utilizar GPU ATI"
html/languages/translations/pt_PT.po:msgid "ATI GPU"
html/languages/translations/pt_PT.po:msgstr "GPU ATI"

html/languages/translations/es.po:msgid "Use ATI GPU"
html/languages/translations/es.po:msgstr "Usar GPU ATI"
html/languages/translations/es.po:msgid "ATI GPU"
html/languages/translations/es.po:msgstr "GPU ATI"

html/languages/translations/fi.po:msgid "Use ATI GPU"
html/languages/translations/fi.po:msgstr "Käytä ATIn GPUta"
html/languages/translations/fi.po:msgid "ATI GPU"
html/languages/translations/fi.po:msgstr "ATIn GPU"

html/languages/translations/it_IT.po:msgid "Use ATI GPU"
html/languages/translations/it_IT.po:msgstr "Utilizzare GPU ATI"
html/languages/translations/it_IT.po:msgid "ATI GPU"
html/languages/translations/it_IT.po:msgstr "GPU ATI"

html/languages/translations/ca.po:msgid "ATI GPU"
html/languages/translations/ca.po:msgstr "GPU ATI"

html/languages/translations/pl.po:msgid "Use ATI GPU"
html/languages/translations/pl.po:msgstr "Używaj karty graficznej ATI"
html/languages/translations/pl.po:msgid "ATI GPU"
html/languages/translations/pl.po:msgstr "Karta graficzna ATI"

html/languages/translations/de.po:msgid "Use ATI GPU"
html/languages/translations/de.po:msgstr "ATI-Grafikprozessor benutzen"
html/languages/translations/de.po:msgid "ATI GPU"
html/languages/translations/de.po:msgstr "ATI Grafikkarte"

html/languages/translations/ru.po:msgid "Use ATI GPU"
html/languages/translations/ru.po:msgstr "Использовать ГП ATI"
html/languages/translations/ru.po:msgid "ATI GPU"
html/languages/translations/ru.po:msgstr "ГП ATI"

html/languages/translations/he.po:msgid "Use ATI GPU"
html/languages/translations/he.po:msgstr "השתמש במעבד גרפי ATI"
html/languages/translations/he.po:msgid "ATI GPU"
html/languages/translations/he.po:msgstr "מעבד גרפי של ATI"

html/languages/translations/fr.po:msgid "Use ATI GPU"
html/languages/translations/fr.po:msgstr "Utiliser le GPU ATI"
html/languages/translations/fr.po:msgid "ATI GPU"
html/languages/translations/fr.po:msgstr "GPU ATI"

html/languages/translations/uk.po:msgid "Use ATI GPU"
html/languages/translations/uk.po:msgstr "Використання ГП ATI"
html/languages/translations/uk.po:msgid "ATI GPU"
html/languages/translations/uk.po:msgstr "Графічний процесор ATI"

@TheAspens
Copy link
Member

@davidpanderson - You had voiced a requested change to this pull request. Given @JuhaSointusalo examples of translators have in fact translated these strings to make them proper grammar in different languages are you still requesting the change?

@lfield
Copy link
Contributor

lfield commented Apr 11, 2019

This PR just changes the string "ATI GPU" to "AMD GPU". If the translations are to be removed this should be done in a separate PR.

@lfield lfield merged commit e57f835 into BOINC:master Apr 11, 2019
@JuhaSointusalo JuhaSointusalo deleted the web-ati-to-amd branch April 11, 2019 17:29
@AenBleidd AenBleidd added this to the Server Release 1.2.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants