-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplication of versioning #2858
Comments
In fact, this is another reason to factor it out of and thus decouple it from To be honest, |
How about extending |
generate_svn_version.sh puts version.h in the source tree so as far as I understand the constant is built into the binary and is copied via install or upgrade. Adding a creating a release.inc file is sort of a similar approach. However the use of generate_svn_version.sh kind of invalidates the comment from @davidpanderson and release.inc should therefore be put in html/inc. But we could make generate_svn_version.sh put release.inc into the source tree and add it to git ignore as is done for svn_version.h. |
First of all the 'server versioning' and generate_svn_version serve two different purposes: the server version should point to something generally understandable, like a version tag, for publication and subject to public inspection. |
Why? Doesn't he just argue to have a single file generated (e.g. in project root) and let all "consumers" use that file where needed? I share that that thought as it is what I meant by "centralized". |
I guess but the C programs already have it included. |
I can't follow. To whom is this addressed? |
The recent server versioning PR #2838 duplicates the functionality of generate_svn_version.sh. For example running
db_dump --version
on the server outputs:The version should be stored on one place place and found by one mechanism. Thoughts?
The text was updated successfully, but these errors were encountered: