Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative approach for server versioning #2861

Merged
merged 6 commits into from
Dec 3, 2018
Merged

Alternative approach for server versioning #2861

merged 6 commits into from
Dec 3, 2018

Conversation

lfield
Copy link
Contributor

@lfield lfield commented Nov 30, 2018

Fixes #2858

Description of the Change

  1. The version detection is now done in generate_svn_version.sh rather than setup_project.py.
  2. release.inc is created in html/inc and added to .gitignore
  3. The link to the repository has been removed to avoid further discussion

@lfield lfield mentioned this pull request Nov 30, 2018
Closed
@brevilo
Copy link
Contributor

brevilo commented Nov 30, 2018

Way better. Now projects can decide when and how often to update those details.

@brevilo brevilo merged commit 75f9044 into master Dec 3, 2018
@brevilo
Copy link
Contributor

brevilo commented Dec 3, 2018

Thanks!

@brevilo brevilo deleted the lfield-alt-version branch December 3, 2018 12:29
@lfield
Copy link
Contributor Author

lfield commented Dec 4, 2018

Upgraded LHC@home Dev. Seems to work fine.
https://lhcathomedev.cern.ch/lhcathome-dev/server_status.php

@drshawnkwang drshawnkwang mentioned this pull request Dec 14, 2018
Closed
@AenBleidd AenBleidd added this to the Server Release 1.2.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bema-aei bema-aei bema-aei left review comments

@brevilo brevilo brevilo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Server Release 1.2.0
Development

Successfully merging this pull request may close these issues.

Duplication of versioning
4 participants
@lfield @brevilo @bema-aei @AenBleidd