Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: default log flags not set at startup #3606

Closed
RichardHaselgrove opened this issue Apr 15, 2020 · 2 comments · Fixed by #3643
Closed

Client: default log flags not set at startup #3606

RichardHaselgrove opened this issue Apr 15, 2020 · 2 comments · Fixed by #3643

Comments

@RichardHaselgrove
Copy link
Contributor

Describe the bug
When the optional file cc_config.xml is absent, the three default log flags (file_xfer, sched_ops, task) remain unset.
If cc_config.xml is present, but no log flags are mentioned in it, the defaults are set.

Steps To Reproduce

  1. Delete or rename cc_config.xml
  2. Restart client
  3. View Event log.

Expected behavior
Default values should be set, as before.

System Information

  • OS: Windows 7,10
  • BOINC Version: 7.16.5 (new in v7.16)

Additional context
Defaults should be set at https://github.com/BOINC/boinc/blob/master/lib/cc_config.cpp#L42

This code was modified on 5 Nov 2019 by 219a540

@RichardHaselgrove
Copy link
Contributor Author

I can't make this work, but setting the default values in the STRUCT definition

struct LOG_FLAGS {
    // If you add anything, you must add it to parse() and write()

    // on by default; intended for all users
    //
    bool file_xfer = true;
        // file transfer start and finish
    bool sched_ops = true;
        // interactions with schedulers
    bool task = true;
        // task start and finish, and suspend/resume

does at least put the right message out at startup.

@RichardHaselgrove
Copy link
Contributor Author

Now being addressed by client: initialize log flags to tasks, sched_ops, file_xfer #3643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant