Drupal: Harden email change procedure #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 21, 2018 09:26
When changing an email, use receives notification at new and old email address. Add checks for previous email address. Also add check for boincuser_delete account to terms of use form. Matches UX from upstream: BOINC#2451 Resolves: https://dev.gridrepublic.org/browse/DBOINCP-436 Also see: * BOINC#2500 * https://boinc.berkeley.edu/trac/wiki/EmailChangeNotification
User may recovert previous email by using a form. This will revert the user's email but s/he must set a new password first.
User may not delete account until seven days after an email change. Additionally, delete account form has a link to the email/password change form.
create_account RPC changed.
tristanolive
requested changes
Jun 21, 2018
| @@ -1555,6 +1630,13 @@ function boincuser_create_account() { | |||
| } | |||
|
|
|||
| // Process input | |||
| // Check this email against previous email addresses. | |||
| $tmpuser = BoincUser::lookup_pr3ev_email_addr($params['email_addr']); | |||
There was a problem hiding this comment.
Typo in function name, probably won't work. 😄
|
I managed to forgot a |
tristanolive
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change will make the Drupal web code match the upstream Web code (PR #2500) for user's email address change. The workflow is described in the boinc wiki.
https://dev.gridrepublic.org/browse/DBOINCP-436