Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project #2716

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Add project #2716

merged 1 commit into from
Oct 8, 2018

Conversation

davidpanderson
Copy link
Contributor

No description provided.

@RichardHaselgrove
Copy link
Contributor

I've checked the list against the comparison chart I attached to #2696, and all seems good - including the new project, DBN Upper Bound, which has not yet been publicly welcomed.

I'm still a bit concerned that our usage of HTTPS is inconsistent. Now that the <web_url> tag is active, we could and perhaps should set the web_urls for these projects to https:

https://www.rnaworld.de/rnaworld/
https://www.gpugrid.net/
https://boinc.bakerlab.org/rosetta/
https://climateprediction.net/
https://asteroidsathome.net/boinc/
https://www.cosmologyathome.org/
https://milkyway.cs.rpi.edu/milkyway/
https://setiathome.berkeley.edu/
https://www.rechenkraft.net/yoyo/
https://www.worldcommunitygrid.org/
https://moowrap.net/
https://www.primegrid.com/
https://www.primaboinca.com/
https://boinc.multi-pool.info/latinsquares/

And, for completeness, these projects cannot yet use https to access their websites. Perhaps we could nudge them gently?

http://quakecatcher.net/sensor
http://radioactiveathome.org/boinc/
http://www.acousticsathome.ru/boinc/
http://casathome.ihep.ac.cn/
http://sat.isa.ru/pdsat/
http://www.enigmaathome.net/
http://gerasim.boinc.ru/
http://srbase.my-firewall.org/sr5/
http://anthgrid.com/dbnupperbound/

Finally, I'm still not quite sure why the plain < url > tags for

http://denis.usj.es/denisathome/
http://einstein.phys.uwm.edu/

have been reverted to http this time. Both projects support using https in

Fetching configuration file from https://denis.usj.es/denisathome/get_project_config.php
Fetching configuration file from https://einstein.phys.uwm.edu/get_project_config.php

which is the primary purpose of this commit. I'm aware of the command line problem raised by @ChristianBeer in #2642, but how many users use this file as the source for command line urls? The number of users still using Version 4 or earlier BOINCs is tiny, and the only other users I can think of being affected are

a) self-ports to unsupported operating systems
b) bulk deployments by corporate users wishing to maintain central control

I think both classes could be expected to do their own research and apply the master url directly where needed?

@AenBleidd
Copy link
Member

I think http://sat.isa.ru/pdsat/ has no work for 2 years already as far as I heard they have no plans to continue but I can be wrong.

I can gently push guys of these projects on Russian boinc forum :
http://www.acousticsathome.ru/boinc/
http://gerasim.boinc.ru/

@ChristianBeer
Copy link
Member

For me the commit message is very non-descriptive and doesn't reflect what is in the code changes. I can already hear someones head banging on his desk in the future because he/she wants to know why the changes were made and "Add project" just doesn't do that.

As for the changes related to Einstein@Home they are fine if the intention of is to represent the master_url and <web_url> represents the url to be used in the browser by the user.

As for the general separation of and <web_url> I think that was needed because the file is used in multiple places where the distinction was needed. I can't remember the exact details. But the master_url is also needed by users who install BOINC on systems with no UI, for example RaspberryPi or similar boards where they attach to existing accounts via boinccmd.

@TheAspens
Copy link
Member

TheAspens commented Oct 2, 2018

My understanding is that the source of the all projects list is this:

https://github.com/BOINC/boinc-site/blob/master/projects.inc
which is used by
https://boinc.berkeley.edu/project_list.php
and the output of that creates the file submitted in this pull request.

If we want to get things updated in the original source, then we need to submit a pull request against https://github.com/BOINC/boinc-site/blob/master/projects.inc with the needed changes. @davidpanderson - is this correct?

I think that things like trying to persuade projects to use things like Let's Encrypt or otherwise move to https should be handled and discussed on tickets outside of this as that discussion confuses the action needed on this pull request. Issue #1345 that @RichardHaselgrove refers to is a great place to discuss that.

@RichardHaselgrove - could you create a pull request against https://github.com/BOINC/boinc-site/blob/master/projects.inc that proposes what needs to be corrected based on how things are today (not how we wish they might be in the future).

@RichardHaselgrove
Copy link
Contributor

@TheAspens: My recollection is that https://github.com/BOINC/boinc-site/blob/master/projects.inc was cited as the definitive source during our working party deliberations, too. And that file was updated 11 days ago, so we should be close to equivalence. I'll try and work up a pull request tomorrow, in time for the committers' call on Thursday. The change of format (data to code) will slow things down, as will validating the other data sources (keywords via KeywordID, plan classes). I think I feel a database coming on...

"What needs to be corrected [today]" would be based on a bias towards using https wherever supported, especially for <web_url> which is used for browser access only: my feeling is (as it was during my stint as release manager) that this presents a professional image for both BOINC and the projects in this age of the promotion of browser security.

The join/master url debate still needs to be resolved through #2642, but I think @ChristianBeer's direction of travel there is to resolve the command line (boinccmd) attachment problem by implementing get_project_config there too. Which leaves Account Managers...

@CharlieFenton
Copy link
Contributor

Both the Mac and Windows installers get the all projects list from the release branch at the following path:win_build/installerv2/redist/all_projects_list.xml. So, from the point of view of building a public release, the copy in the release branch at that location is the one that matters.

I programmed the Mac installer so that it writes the all_projects_list.xml file to the BOINC Data directory ** only** if there is not already one there (in the case of installing over a previously installed BOINC.) This is because an exiting all_projects_list.xml file will usually be more recent, since the client checks the server every 14 days and downloads the file if the one on the server is newer than the local copy. However, I don't think the Windows installer has this logic.

@CharlieFenton
Copy link
Contributor

I have confirmed that the all_projects_list.xml file added to the 7.14 branch by commit 50e4ed8 is identical to all the following:

So I will go ahead and tag 7.14.1 and build a Mac installer.

@RichardHaselgrove
Copy link
Contributor

I have confirmed ...

Thanks Charlie - that saves me a tough job (though I might still build that database at leisure to facilitate future tests).

I'll still make the PR for updating web urls to https where viable, but let's not regard it as a blocker for v7.14

@RichardHaselgrove
Copy link
Contributor

I have opened BOINC/boinc-site#3 for these changes. I find I don't currently have write access to the boinc-site repo, so these changes are derived from a personal fork.

@davidpanderson
Copy link
Contributor Author

Why hasn't this been merged?

@CharlieFenton CharlieFenton merged commit 0c9081d into master Oct 8, 2018
@AenBleidd AenBleidd deleted the dpa_project_list3 branch December 10, 2018 13:40
@davidpanderson davidpanderson restored the dpa_project_list3 branch July 30, 2019 01:46
@AenBleidd AenBleidd deleted the dpa_project_list3 branch September 24, 2019 08:24
@AenBleidd AenBleidd moved this from Review to Done in Client Release 7.14 Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants