Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: add consent preferences to column view of project preferences page. #2916

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

drshawnkwang
Copy link
Contributor

Fixes #2857

Description of the Change
Project Preferences column view now has the consent preferences displayed.

Release Notes
Include consent preferences in the Project Preferences column view.

@drshawnkwang
Copy link
Contributor Author

@lfield, this is a simple fix for issue #2857

@Rytiss
Copy link
Contributor

Rytiss commented Jan 23, 2019

Having looked through the code but not having ran it, I believe that while this shows the pref in the column view, it mismatches the number of table cells: consent_show_cols() (/html/inc/prefs_util.inc#L190) has the global $venues but does not use it, so it will only generate a single column, whereas other prefs such as privacy prefs will generate as many columns as there are venues.

Now, consent is a global, venue-spanning option, so it makes sense for it to not be repeated for each venue. However, so as not to break the table layout, colspan param could be applied to the value cell, matching the venue count, in both show_value() and the hardcoded table cell with dashes in consent_show_cols().

venue_show() method also does not generate extra columns, so it is visible how it behaves differently. It should probably be fixed too.

Copy link
Contributor

@Rytiss Rytiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in a PR comment.

@drshawnkwang
Copy link
Contributor Author

@Rytiss, the latest comment should fix what you are asking about. I attached a screenshot of the table generated by the newest code. Please evaluate if this is what you are looking for.

boincpr2916_table01

@Rytiss Rytiss merged commit dc21dbd into BOINC:master Feb 1, 2019
@Rytiss
Copy link
Contributor

Rytiss commented Feb 1, 2019

Looks good, merged.

@drshawnkwang drshawnkwang deleted the sak_fix-consentprefs-columnview branch February 1, 2019 15:49
@AenBleidd AenBleidd added this to the Server Release 1.2.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDPR not showing in alternate view
3 participants