Add extra freetype lib only when required #3578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BOINC manager needs to deal with fonts, but nothing else, really. To always incude it may have unexpected side-effects, as reported for the CLI-only build for OpenWrt: openwrt/packages#11768 (comment)
|
For platforms that have a BOINC screensaver I believe that the default BOINC screensaver boincscr also uses freetype. |
|
On Windows these 3 projects are linking with freetype. And there is no Manager among them: I believe in linux situation should be pretty much the same |
1715173329
pushed a commit
to immortalwrt/packages
that referenced
this pull request
Apr 9, 2020
In reaction to a comment by @hnyman in openwrt/packages#11768 (comment) on BOINC embracing too many libraries it finds on its build host, the inclusion of the freetype library is now excluded by an embracing "if" statement. The patch is presented to BOINC upstream at BOINC/boinc#3578 Signed-off-by: Steffen Möller <moeller@debian.org>
|
If not building the manager, the compilation works. I cannot tell what configure options trigger the building of these "slideshow" or "graphics" apps. |
nmeyerhans
pushed a commit
to nmeyerhans/packages
that referenced
this pull request
May 4, 2020
In reaction to a comment by @hnyman in openwrt#11768 (comment) on BOINC embracing too many libraries it finds on its build host, the inclusion of the freetype library is now excluded by an embracing "if" statement. The patch is presented to BOINC upstream at BOINC/boinc#3578 Signed-off-by: Steffen Möller <moeller@debian.org>
farmergreg
pushed a commit
to farmergreg/packages
that referenced
this pull request
Sep 8, 2020
In reaction to a comment by @hnyman in openwrt#11768 (comment) on BOINC embracing too many libraries it finds on its build host, the inclusion of the freetype library is now excluded by an embracing "if" statement. The patch is presented to BOINC upstream at BOINC/boinc#3578 Signed-off-by: Steffen Möller <moeller@debian.org>
farmergreg
pushed a commit
to farmergreg/packages
that referenced
this pull request
Sep 8, 2020
In reaction to a comment by @hnyman in openwrt#11768 (comment) on BOINC embracing too many libraries it finds on its build host, the inclusion of the freetype library is now excluded by an embracing "if" statement. The patch is presented to BOINC upstream at BOINC/boinc#3578 Signed-off-by: Steffen Möller <moeller@debian.org>
|
I just saw the "Waiting for Response"-flag. That is not a response from me, is it? |
It's exactly for you. You fix is not correct in this PR |
|
Shall we close this PR, then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BOINC manager needs to deal with fonts, but nothing else, really. To always include it may have unexpected side-effects, as reported for the CLI-only build for OpenWrt: openwrt/packages#11768 (comment)
Description of the Change
BOINC_EXTRA_LIBS are grasping all libraries of a list manually aggregated in configure.ac. Since the freetype library is only dealing with fonts, and fonts are used only the GUI, these should not be linked against if only building the command-line interface.
Admittedly, I am not really liking this patch but to do more may require a bit of an extra discussion. The BOINC_EXTRA_LIBS shall possibly be divided up - one set of libs for the command line, one for the GUI, and one that the two share.
Release Notes
N/A