Add priority options to remote job submission #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not necessarily the right thing.
For example, nanoHUB submits batches of jobs that are mixtures
of speculative and user-submitted;
these simply need to be given low and high priorities.
The way things work now:
- if you want allocation-based prioritization,
set the "allocation_priority" flag in the request object
(Python or PHP API)
- or set the "priority" field in the request object;
that sets the priority of all the jobs in the batch
- or set the "priority" field of jobs in the batch.
Updated wiki docs accordingly.
Also fixed a bug in the test script
(note to self: adding an object to an array adds a reference, not a copy).
Codecov Report
@@ Coverage Diff @@
## master #3947 +/- ##
=========================================
Coverage 16.56% 16.56%
Complexity 752 752
=========================================
Files 134 134
Lines 13115 13115
Branches 1631 1631
=========================================
Hits 2172 2172
Misses 10811 10811
Partials 132 132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote job submission was always using allocation-based prioritization.
This is not necessarily the right thing.
For example, nanoHUB submits batches of jobs that are mixtures
of speculative and user-submitted;
these simply need to be given low and high priorities.
The way things work now:
set the "allocation_priority" flag in the request object
(Python or PHP API)
that sets the priority of all the jobs in the batch
Updated wiki docs accordingly.
Also fixed a bug in the test script
(note to self: adding an object to an array adds a reference, not a copy).
Fixes #
Description of the Change
Alternate Designs
Release Notes