client and wrapper: fix process priority mismatch #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out we have two different encodings of process priority: 1) specified in cc_config.xml and used by the client: 0 (low) to 4 (high) 2) specified in job.xml and used by the wrapper: 1 (low) to 5 (high). This didn't cause any problems until recently when I added code to pass the cc_config.xml info to the wrapper; it was interpreting it on the 1-5 scale. Fix: have the wrapper convert it (add one). Also: I forgot to have the client actually put the priority into in the app_init_data.xml file.
| @@ -747,7 +747,10 @@ int TASK::run(int argct, char** argvt) { | |||
| priority_val = 0; | |||
| } else { | |||
| if (aid.process_priority > 0) { | |||
There was a problem hiding this comment.
Please also change this test to
if (aid.process_priority > CONFIG_PRIORITY_UNSPECIFIED) {
CharlieFenton
added a commit
that referenced
this pull request
Aug 28, 2020
client and wrapper: fix process priority mismatch (cherry picked from commit 548cf03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we have two different encodings of process priority:
This didn't cause any problems until recently when I added code
to pass the cc_config.xml info to the wrapper;
it was interpreting it on the 1-5 scale.
Fix: have the wrapper convert it (add one).
Also: I forgot to have the client actually put the priority into
in the app_init_data.xml file.