New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: calculate max disk usage based on user prefs correctly. #4923
Conversation
If max_used_gb or max_used_pct are zero (in client prefs) treat as "no limit".
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4923 +/- ##
============================================
- Coverage 10.43% 10.43% -0.01%
Complexity 1046 1046
============================================
Files 278 278
Lines 35829 35831 +2
Branches 8114 8114
============================================
Hits 3739 3739
- Misses 31719 31721 +2
Partials 371 371
|
@lfield, would be nice if you could take a look |
This branch has been built and the updated cgi binary has been updated for our Dev project. |
It seems to be working fine on LHC@home dev. I am not sure how to test the actual fix as we don't have tasks requiring over 100GB of disk. |
This may be a dumb question, but is it possible to generate a task with a lot of bloat to get to 100 gb? Probably easier said than done. |
I updated the template of one of our apps so that
In the client I first set the 'Use no more than' option to 10GB and no task was received. I then set this value to zero and received a task. The client is shown bellow.
|
@lfield, thank you for testing this. I believe now you can merge it |
If max_used_gb or max_used_pct are zero (in client prefs) treat as "no limit".
I haven't tested this.