Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for systems where library directory is named lib64 #5085

Merged
merged 3 commits into from Feb 12, 2023
Merged

Account for systems where library directory is named lib64 #5085

merged 3 commits into from Feb 12, 2023

Conversation

CyberTailor
Copy link
Contributor

  • Use $(libdir) in automake
  • Use GNUInstallDirs in CMake

@AenBleidd AenBleidd self-assigned this Feb 5, 2023
@AenBleidd AenBleidd added this to Backlog in BOINC Client/Manager via automation Feb 5, 2023
@AenBleidd AenBleidd added this to the Client/Manager 7.22.1 milestone Feb 5, 2023
@AenBleidd AenBleidd moved this from Backlog to In Progress in BOINC Client/Manager Feb 5, 2023
@CyberTailor
Copy link
Contributor Author

CyberTailor commented Feb 5, 2023 via email

BOINC Client/Manager automation moved this from In Progress to Reviewed Feb 12, 2023
@AenBleidd AenBleidd merged commit bc5c27e into BOINC:master Feb 12, 2023
BOINC Client/Manager automation moved this from Reviewed to Merged Feb 12, 2023
@jengelh
Copy link

jengelh commented May 16, 2023

I've only seen this now because of the v7.22.1 announcement.

This change is wrong. ${libdir} is for libraries only, but examples and server daemons are programs (or outright something else like data files). The "dumping ground for everything else" is indeed ${prefix}/lib.

Please revert this.

@AenBleidd
Copy link
Member

I believe this should be fixed, bit reverted.
@CyberTailor, I believe when installing executables, ${libexecdir} should be used instead.
Could you please take a look and fix?

@CyberTailor
Copy link
Contributor Author

I believe this should be fixed, bit reverted. @CyberTailor, I believe when installing executables, ${libexecdir} should be used instead. Could you please take a look and fix?

I didn't note that. Yes, ${libexecdir} or ${bindir} should be used for daemon programs.

@CyberTailor CyberTailor mentioned this pull request May 17, 2023
Merged
@CyberTailor
Copy link
Contributor Author

This is not urgent because some software installs executables to libdir too.

Created #5239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AenBleidd AenBleidd AenBleidd approved these changes

Assignees

@AenBleidd AenBleidd

Labels
C: Build System C: Client - Build P: Minor PR: Reviewed T: Bugfix
Projects
No open projects
BOINC Client/Manager
Merged
Milestone
Client/Manager 7.22.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CyberTailor @jengelh @AenBleidd