[linux] Move all fcgi dependent stdio functions to the separate 'boinc_stdio.h' header only file

[AenBleidd]

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

[codecov]

Codecov Report

Merging #5096 (11739f2) into master (bc5c27e) will increase coverage by 7.05%.
The diff coverage is 3.65%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5096      +/-   ##
============================================
+ Coverage      3.79%   10.85%   +7.05%     
- Complexity        0     1064    +1064     
============================================
  Files           174      279     +105     
  Lines         28196    35989    +7793     
  Branches       6797     8257    +1460     
============================================
+ Hits           1071     3907    +2836     
- Misses        27084    31690    +4606     
- Partials         41      392     +351     

Impacted Files	Coverage Δ
db/boinc_db.cpp	0.13% <0.00%> (+<0.01%)	⬆️
db/boinc_db_types.h	0.00% <ø> (ø)
db/db_base.cpp	0.77% <0.00%> (ø)
lib/base64.cpp	79.03% <ø> (+1.44%)	⬆️
lib/cert_sig.cpp	0.00% <0.00%> (ø)
lib/coproc.cpp	0.00% <0.00%> (ø)
lib/coproc.h	0.00% <ø> (ø)
lib/crypt.cpp	0.00% <0.00%> (ø)
lib/diagnostics.cpp	0.00% <0.00%> (ø)
lib/filesys.cpp	0.00% <0.00%> (ø)
... and 168 more

[AenBleidd]

@davidpanderson, could you please review this?
This fix is needed to fix build of libboinc and server tools when using FastFCGI with the new gcc 11 that has a breaking change of malloc prototype making it incompatible with FastCGI methods overloads.

@lfield, since this is quite a big fix that could probably touched smth that was not intended to be touched, could you please test this on the test server with FastCGI enabled?

Thank you both in advance.

[AenBleidd]

@davidpanderson, could you please review this PR? Thank you in advance

[davidpanderson]

I didn't look at this in detail but it seems like the right approach.

BTW, for large changes like this it's better to not include unrelated edits like trailing spaces;
that makes the diff harder to read.

[AenBleidd]

BTW, for large changes like this it's better to not include unrelated edits like trailing spaces;
that makes the diff harder to read.

That's done automatically by my code editor. Pardon, will clean it up next time.

Thank you for the review

[CharlieFenton]

Unnecessary changes such as deleting trailing spaces also interferes with using GIT's blame function when trying to determine when and why a line of code had functional changes, and who made the change.