Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Add snap build #5107

Merged
merged 1 commit into from Feb 20, 2023
Merged

[Linux] Add snap build #5107

merged 1 commit into from Feb 20, 2023

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Feb 19, 2023

Add snap build
Fix #4927
Fix #2485
Fix #4042

@davidpanderson Please review this PR.

Snap itself run inside core22 that it mean ubuntu 22.04 like.
Tested on online vm ubuntu 20.04. with gui and x11.

ubuntu_20 04
x11

@AenBleidd
Copy link
Member

I'll review this next week.
Thank you for the PR

@talregev
Copy link
Contributor Author

talregev commented Feb 19, 2023

I'll review this next week. Thank you for the PR

As you told me in private you decided to be "tough" with me.
As shown in other PRs, you don't interested in my input. You falsify any of my input, most of the time with no proof.
You only interested only in your authority. This is no way of collaborate. I want other person opinion and will review my PRs.
@davidpanderson Please review my PR.

@AenBleidd
Copy link
Member

OSX failure is not related to this particular PR. It should be fixed automatically with the next release of GitHub Actions OSX runner image.

Ref: actions/runner-images#7125

@AenBleidd
Copy link
Member

As you told me in private you decided to be "tough" with me.

No. I told you that I'll never be as loyal to you as before and will treat you equally to any other contributor.

As shown in other PRs, you don't interested in my input.

I didn't tell you this. I just told you that you should never delegate unfinished work to others and push your line.

You falsify any of my input, most of the time with no proof.

I always give you the reason. Also, since I'm a maintainer, I always have the final word. And you have to deal with that.

You only interested only in your authority.

This is only your opinion. I try to do best for this project.

This is no way of collaborate.

If you'll act this way - you're right, no way.

I want other person opinion and will review my PRs. @davidpanderson Please review my PR.

This is my area of responsibility, and David trusts me here.
If you want to collaborate - you should change your behavior.
Because it could happen that I'm the only person who replies to you at all.
Please think about it

@AenBleidd AenBleidd moved this from Backlog to In Review in BOINC Client/Manager Feb 19, 2023
Copy link
Member

@AenBleidd AenBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general PR looks fine.
Please fix some minor comments

snap/gui/boinc.desktop Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
set-client-version.py Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
BOINC Client/Manager automation moved this from In Review to Reviewed Feb 20, 2023
@AenBleidd
Copy link
Member

LGTM. Thank you for the PR.

@AenBleidd AenBleidd merged commit c343c7d into BOINC:master Feb 20, 2023
BOINC Client/Manager automation moved this from Reviewed to Merged Feb 20, 2023
@talregev talregev deleted the TalR/snap_test6 branch February 22, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Implement snap package for client and Manager Use snap for Linux install Flatpak/Snap support
2 participants