clean up screensaver code #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AenBleidd
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Looks ok to me. It would be nice if @CharlieFenton reviews this as well
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5197 +/- ##
=========================================
Coverage 10.86% 10.86%
Complexity 1064 1064
=========================================
Files 279 279
Lines 35980 35980
Branches 8257 8257
=========================================
Hits 3911 3911
Misses 31677 31677
Partials 392 392 |
CharlieFenton
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix formatting in screensaver_x11.cpp
Remove unused RESULT* arg in terminate functions
Don't use reference params if no reason to