Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manager] Improve consistency of control labels and accelerators #5202

Merged
merged 5 commits into from May 25, 2023
Merged

[Manager] Improve consistency of control labels and accelerators #5202

merged 5 commits into from May 25, 2023

Conversation

BrianNixon
Copy link
Contributor

@BrianNixon BrianNixon commented Apr 17, 2023

Make accelerators consistent throughout:

  • Exit → Ex̲it
  • Close → C̲lose
  • C̲ancel → Cancel (doesn’t need an accelerator; that’s what the Esc key is for)
  • Save → S̲ave
  • Help → H̲elp (except in simple view, where none of the buttons has an accelerator)

Also remove some extraneous full stops from the end of tooltips. (There are many more which could be changed, but they would need all the translations updating, which is a much bigger job.)

@BrianNixon BrianNixon marked this pull request as draft April 17, 2023 09:26
@BrianNixon BrianNixon marked this pull request as ready for review April 17, 2023 09:40
@talregev
Copy link
Contributor

talregev commented Apr 17, 2023

Please share a screenshots, before and after. Thank you!

@BrianNixon
Copy link
Contributor Author

Actually most people won’t see any change, given that UIs these days by default hide keyboard accelerators…

Before:
Screenshot of the advanced options dialog buttons, before the proposed change

After:
Screenshot of the advanced options dialog buttons, after the proposed change

@talregev
Copy link
Contributor

Actually most people won’t see any change, given that UIs these days by default hide keyboard accelerators…

Before: Screenshot of the advanced options dialog buttons, before the proposed change

After: Screenshot of the advanced options dialog buttons, after the proposed change

Thank you!

@AenBleidd
Copy link
Member

While in general PR looks ok, I have to put it on hold because we have plans to do a release soon, and this particular PR invalidates a lot of translation strings. I don't want to push translators now, and don't want to delay a release another month.
Thank you for understanding.

@BrianNixon
Copy link
Contributor Author

BrianNixon commented Apr 17, 2023

this particular PR invalidates a lot of translation strings

Which ones? AFAICT, every ‘new’ string in this PR is already in use somewhere.

@AenBleidd
Copy link
Member

Which ones? AFAICT, every ‘new’ string in this PR is already in use somewhere.

Every translatable string. Even if you change just a dot, it will invalidate the translated line completely.

@AenBleidd
Copy link
Member

Ok, I'll double check that later

@AenBleidd AenBleidd moved this from Backlog to In Progress in BOINC Client/Manager May 14, 2023
@AenBleidd AenBleidd moved this from In Progress to In Review in BOINC Client/Manager May 14, 2023
@AenBleidd
Copy link
Member

@BrianNixon, could you please update your PR to resolve conflicts?
Thank you in advance.
Everything else looks fine to me.

BOINC Client/Manager automation moved this from In Review to Reviewed May 25, 2023
@AenBleidd AenBleidd merged commit af19b41 into BOINC:master May 25, 2023
41 checks passed
BOINC Client/Manager automation moved this from Reviewed to Merged May 25, 2023
@BrianNixon BrianNixon deleted the manager_labels branch May 26, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants