New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manager] Improve consistency of control labels and accelerators #5202
Conversation
Please share a screenshots, before and after. Thank you! |
While in general PR looks ok, I have to put it on hold because we have plans to do a release soon, and this particular PR invalidates a lot of translation strings. I don't want to push translators now, and don't want to delay a release another month. |
Which ones? AFAICT, every ‘new’ string in this PR is already in use somewhere. |
Every translatable string. Even if you change just a dot, it will invalidate the translated line completely. |
Ok, I'll double check that later |
@BrianNixon, could you please update your PR to resolve conflicts? |
Make accelerators consistent throughout:
Esc
key is for)Also remove some extraneous full stops from the end of tooltips. (There are many more which could be changed, but they would need all the translations updating, which is a much bigger job.)