Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: add script to notarize BOINC executables #5238

Merged
merged 2 commits into from May 17, 2023
Merged

Conversation

CharlieFenton
Copy link
Contributor

Mac: add script to notarize BOINC Installer, Uninstaller, stand-alone client and AddRemoveUser utility.

As of MacOS 10.15 Catalina, the OS does not allow the user to run downloaded software unless it has been "notarized" by Apple. This PR adds the mac_installer/notarize_boinc.sh script, which can be run to notarize the downloadable BOINC executables after building the installer, uninstaller, etc. with the mac_installer/release_boinc.sh script.

Instructions for running both mac_installer/release_boinc.sh and mac_installer/notarize_boinc.sh can be found in the comments near the top of each script.

I have tested these changes and this PR will be ready to merge as soon as CI checks finish.

@AenBleidd
Copy link
Member

@CharlieFenton, I can fix trailing spaces for you if you want

@CharlieFenton
Copy link
Contributor Author

@AenBleidd Thank you. I already did it.

Though I recently set my Xcode to delete trailing spaces, it only does that for lines I edit. These lines with trailing spaces were present in my file (locally) before I changed that Xcode setting, and they were not lines I modified today. Since this is the first time I've added this file to the repository, your earlier elimination of trailing spaces was not applied to it.

The biggest annoyance about this source code check is that all CI checks are started again after the developer fixes the trailing spaces. Hopefully, i won't run into this again.

BOINC Client/Manager automation moved this from Backlog to Reviewed May 17, 2023
@AenBleidd
Copy link
Member

The biggest annoyance about this source code check is that all CI checks are started again after the developer fixes the trailing spaces. Hopefully, i won't run into this again.

I was thinking about optimizations of our CI to skip unrelated checks (e.g. if there are only Android changes, there is no need to rerun all other CIs) but I haven't looked into this more deeply.

Thank you for the fix. PR looks good to me.

@AenBleidd AenBleidd merged commit 8f63760 into master May 17, 2023
41 checks passed
BOINC Client/Manager automation moved this from Reviewed to Merged May 17, 2023
@CharlieFenton CharlieFenton deleted the mac_notarize_script branch May 20, 2023 13:03
CharlieFenton pushed a commit that referenced this pull request May 21, 2023
Mac: add script to notarize BOINC executables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants