Float error #13
Merged
Float error #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 29, 2020 13:47
…ugh correspondence table
This was referenced Jul 6, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request, is to correct floating point errors which occurs when transforming flows from xlsb to csv. The pull request also reenables extraction of determining flows, adds aggregate and disaggregate flows, and cleans up a bit using pylama.
Many files have changed in this pull request, but most is due to the correction of syntax recommendations when running
pylama -i E501, since this has not been done before.Main file changes:
csv2rdf.py, In the extraction of flows from the .csv file, we find whether a flow is an aggregate flow or a disaggregate flow. If it is aggregate, we add a isPartOf link between the parent flow, and the child flow.excel2csv.py, In the conversion from excel to csv, we aggreagte disaggregate flows for each country, as a way to reintroduce determining flows. Each flow object now has a single activity, but we also save disaggregate flows, so no information is lost. Using the new correspondance table between flow objects and aggregate flow objects to determine flows, we no longer need a square HUSE and HSUP table.