Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One cycle learning rate scheduler in convmixer #47

Merged
merged 4 commits into from
Nov 10, 2021
Merged

One cycle learning rate scheduler in convmixer #47

merged 4 commits into from
Nov 10, 2021

Conversation

skpig
Copy link
Collaborator

@skpig skpig commented Nov 6, 2021

About issue #43. @xperzy

  1. add one cycle learning rate scheduler to convmixer
  2. add test file

Copy link
Collaborator

@xperzy xperzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the test file import line, other part looks good to me

# limitations under the License.

import unittest
from ..utils import OneCycleLRScheduler
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from ..utils can be modified to from utils, so that in ConvMixer/ folder, we can use command python -m unittest to performs the unit test.

Copy link
Collaborator

@xperzy xperzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xperzy xperzy merged commit a68e860 into BR-IDL:develop Nov 10, 2021
@skpig skpig mentioned this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants