New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#49: Create the "cikit-webserver" role #90
Conversation
cmf/all/.cikit/vars/web-server.yml
Outdated
--- | ||
web_server_vhosts: | ||
- name: "{{ (site_url.split('//') | last) if site_url is defined and localhost else 'JenkinsCI' }}" | ||
root: "{{ webroot }}/{{ '' if site_url is defined and localhost else '%1/' }}docroot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Need to have the builds as subdomains (sort of VirtualDocumentRoot
) when only Nginx is used.
beee118
to
5889725
Compare
…t an option there
Notes for the record in changelog (manual actions)
|
@lokeoke, @temoor-gilmutdinov the PR is ready to be reviewed but still WIP. I would appreciate your time to looking at this. The tests I ran: Create the project. cikit self-update --version=issues/49
cikit init --project=webserver
cd webserver Check Nginx operation in a VM built from scratch. EXTRA_VARS="--web-server=nginx --php-version=7.1 --nodejs-version=6 --ruby-version=2.4.0 --solr-version=no --mssql-install=no" vagrant up Create a droplet with Nginx and ensure builds are available. cikit matrix/droplet --limit=HOSTNAME --droplet-add
cikit provision --limit=HOSTNAME.DROPLET Destroy the previous machine and check Nginx operation in a VM built from scratch. vagrant destory -f
EXTRA_VARS="--web-server=apache2 --php-version=7.1 --nodejs-version=6 --ruby-version=2.4.0 --solr-version=no --mssql-install=no" vagrant up Create a droplet with Apache 2 and ensure builds are available. cikit matrix/droplet --limit=HOSTNAME --droplet-delete=DROPLET
cikit matrix/droplet --limit=HOSTNAME --droplet-add
cikit provision --limit=HOSTNAME.DROPLET Change web server on demand inside of VM and check whether an application behaves correctly. CIKIT_TAGS="web-server" EXTRA_VARS="--web-server=nginx" vagrant provision Ensure the error about the impossibility to change the server on an existing CI droplet is gotten. cikit provision --limit=HOSTNAME.DROPLET |
@lokeoke, @temoor-gilmutdinov, I'm gonna merge this on the weekend since the tests are passing. So, I'd appreciate your opinions. |
…chosen web server
Merge has been scheduled for February 3, 2018 (233bf59#diff-ec969b7d93a4e2e93c446ab2df13ae70R3). |
…on to README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to test it though it's a cool feature and I like how upgrade path is provided 👍
docs/_changelog/2018-02-04/README.md
Outdated
|
||
## Required manual actions | ||
|
||
Right after updating the package via `cikit self-update` please make sure all the projects you have based on CIKit will receive the following modifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it should end with colon(:
)
fdd1f96
#49