ENH: Remove DeformationField parameter from GenericTransformImage #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://www.icts.uiowa.edu/jira/browse/PREDICTIMG-1667 The GenericTransformImage template function isn't used that many places. In most it's clear that either a DeformationField or a Transform is passed in. A few places in BRAINSCut it looks like both are passed in, but in practice only one or the other is actually defined. The way GenericTransformImage was actually written, if both a transform and a displacement field are passed in, the transform is ignored. So I felt justified in enforcing that at the point of call. If needed, a DisplaceFieldTransform is created and the Displacement Image is passed in. The biggest 'hidden' change this brings about is that the DisplacementField type is defined as itk::Image<itk::Vector<float,3>,3> but the transform parameter type is double, so I changed type DisplacementField type so it was compatible with the Transform type.
Chaircrusher
pushed a commit
that referenced
this pull request
May 1, 2013
ENH: Remove DeformationField parameter from GenericTransformImage
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.icts.uiowa.edu/jira/browse/PREDICTIMG-1667
The GenericTransformImage template function isn't used that many
places. In most it's clear that either a DeformationField or
a Transform is passed in. A few places in BRAINSCut it looks like
both are passed in, but in practice only one or the other is
actually defined.
The way GenericTransformImage was actually written, if both a
transform and a displacement field are passed in, the transform
is ignored. So I felt justified in enforcing that at the
point of call. If needed, a DisplaceFieldTransform is created
and the Displacement Image is passed in.
The biggest 'hidden' change this brings about is that the
DisplacementField type is defined as
itk::Imageitk::Vector<float,3,3> but the transform parameter
type is double, so I changed type DisplacementField type so it
was compatible with the Transform type.