BUG: Three test failures are fixed after recent changes to BCD #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three tests of BCD were failing after recent changes: 1) BCD_writeBranded2DImage because of recent changes in MakeBranded2DImage function. 2-3) BCD_outputLandmarksInACPCAlignedSpace and BCD_outputLandmarksInInputSpace are failed because half of voxel shift in mid_prim_inf landmarks. I inspected the new results by Slicer, and all other landmarks are placed at the right location. Also, half of voxel shift is acceptable for the mid_prim_inf. This fiducial has uncertainty of 2-3 voxels. Therefore, I replace the previous baselines with the new correct results to fix the test failures.
|
@hjmjohnson : please review this. |
hjmjohnson
added a commit
that referenced
this pull request
Jul 12, 2013
BUG: Three test failures are fixed after recent changes to BCD
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three tests of BCD were failing after recent changes:
MakeBranded2DImage function.
2-3) "BCD_outputLandmarksInACPCAlignedSpace" and
"BCD_outputLandmarksInInputSpace" were failed because half of voxel shift
in mid_prim_inf landmark.
I inspected the new results by Slicer, and all other landmarks are
placed at the right locations. Also, half of voxel shift is acceptable
for the mid_prim_inf. This fiducial has uncertainty of 2-3 voxels.
Therefore, I replace the previous baselines with the new correct results
to fix the test failures.