ENH: Output precision type is added to BRAINSTransformConvert #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjmjohnson : Please review. I tested this patch based on the new version of transform file reader/writer filters, and all tests are passed successfully. |
A new flags are added to BRAINSTransformConvert tool: --outputPrecisionType This flag can be set as "float" or "double", and it can work well with other options like outputTransformType. This patch is tested and works properly based on the last version of ITK that includes updated transform file reader/writer filters. The updated filters can convert their input transforms to the requested output precision type automatically. Testsuite is changed to add float precision tests. Number of tests are increased from 63 to 125 and all of them are passed successfully. "100% tests passed, 0 tests failed out of 125"
ghost
assigned
hjmjohnson
added a commit
that referenced
this pull request
Sep 18, 2013
ENH: Output precision type is added to BRAINSTransformConvert
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new flags are added to BRAINSTransformConvert tool:
--outputPrecisionType
This flag can be set as "float" or "double", and it can work well with
other options like outputTransformType.
This patch is tested and works properly based on the last version of ITK
that includes updated transform file reader/writer filters.
The updated filters can convert their input transforms to the requested
output precision type automatically.
Testsuite is changed to add float precision tests. Number of tests are
increased from 63 to 125 and all of them are passed successfully.
"100% tests passed, 0 tests failed out of 125".
This patch can be merged safely.