Cmake Bugfix: install rpath for pycaffe (replacement of #1897) #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerei
changed the title
Nerei
force-pushed
the
bugfix/install_rpath_for_pycaffe
branch
from
659b9fe
to
3f1e937
Compare
added 2 commits
February 22, 2015 19:56
… was overwritten with symlink created at build time and installed with install(DIRECTORY ...)
Nerei
force-pushed
the
bugfix/install_rpath_for_pycaffe
branch
from
3f1e937
to
645aa03
Compare
|
@Nerei Hey, thanks for figuring this out. This works for me. @shelhamer I'm for merging this. |
shelhamer
added a commit
that referenced
this pull request
Feb 22, 2015
[cmake] fix install rpath for pycaffe
|
Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proper replacement of #1897 and contains bugfix with RPATH for pycaffe in install-tree.
The problem was:
<caffe_source>/python/caffe/_caffe.so -> <cmake_build_dir>/lib/_caffe.so_caffe.soand updated RPATH properly<caffe_source>/python/caffedirectory, and overwrote installed earlier_caffe.sowith the symlink ;-)))