Thread start and stop revamp #2383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK, but using CHECK instead of the boolean return value is debatable I think. |
|
|
||
| /** Will not return until the internal thread has exited. */ | ||
| bool WaitForInternalThreadToExit(); |
There was a problem hiding this comment.
Should a public method be deleted without being labeled as @deprecated for some time?
There was a problem hiding this comment.
I think it's supposed to be implementation details of the thread mechanism used internally, so I would say yes.
- Interrupt the thread before waiting on join - Provide a method for looping threads to exit on demand - CHECK if start and stop succeed instead of returning an error
Closed
|
No longer needed with the switch in #4563. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off #2367. Now that threads can be waiting on locks or condition variables, it can be necessary to interrupt them to stop the app. This PR makes sure stopping a Caffe thread always calls interrupt before waiting on join. It also provides a method 'must_stop' that can be tested when running in a loop to exit on demand.
Start and stop methods now fail a CHECK instead of returning a boolean error, given that the application doesn't really have a way to recover from this type of error.