Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
AdaDelta Solver (v3) #2782
changed the title from
AdaDelta Solver (attempt number 3)
Jul 18, 2015
referenced this pull request
Aug 4, 2015
@matthiasplappert Thanks for your great PR to introduce AdaDelta solver into Caffe!
The remaining work include:
Please modify and update according to the reviews.
Update on this: This branch is now up-to-date with master and all feedback has been addressed. The tests pass locally and I expect them to also pass on the CI.
Please review my changes and let me know if everything else is required on my end, e.g. cleaning up the commit history (not sure how you usually handle this). I've also pointed out the relevant commits in each feedback discussion to hopefully help with reviewing the changes.
Finally, I have one suggestion to make: having all solvers in one relatively big file (
@matthiasplappert Thanks a lot for the update. I will review the changes today.
Yes, this is quite a problem. I expect to send a solver refactor PR to split solver.cpp and extract common code for these adaptive gradient solvers, after merging AdaDelta and Adam (#2856).
@matthiasplappert I just made a few comments above. Let's get the following work done and I think this PR will be ready:
@matthiasplappert a note about history: instead of squashing to a single commit, please squash the commits by each author into a single commit. This will leave three commits by @mohomran @kevinbache and yourself. In future work please make use of rebase instead of merge, as our policy is to only have merge commits for PRs. Thanks.
@ronghanghu Thanks for the thorough review! I'm still very new to caffe, so your feedback is very much appreciated.
I've addressed the remaining feedback and cleaned up the commit history (also: no more merges). All tests pass locally (not sure if Travis will pick this up since the branch was force-pushed to override the history). Let me know if anything else needs to be done before we can land this in master.