Test solvers on fixed hdf5 data #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelhamer
force-pushed
the
solver-test-data
branch
from
cae1bc8
to
f9e2ec1
Compare
Rely on fixed hdf5 data for determinism of solver tests. - draw random Gaussian data and targets for test and save to hdf5 - use the same data for all tests without constant / gaussian condition previously needed for accumulation - avoid test artifacts due to order of random draws in dummy data
shelhamer
force-pushed
the
solver-test-data
branch
from
f9e2ec1
to
6019246
Compare
|
Cool, LGTM. Feel free to merge as makes sense with #2870. |
This was referenced Aug 9, 2015
Closed
Merged
|
Merging as I think this is an improvement in itself and reduces the RNG confusion. The multi-GPU tests will be handled by #2870. |
shelhamer
added a commit
that referenced
this pull request
Aug 9, 2015
Test solvers on fixed hdf5 data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simplicity and determinism the solver tests are given fixed hdf5 input.
The current arrangement of using random dummy data introduces subtleties in the order of execution that add complexity and test artifacts.
In particular, it makes it awkward to test accumulation and multi-GPU solving.