fix python wrapper issues #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* don't specify the fname of lib to load (Mac and Win32 don't have 'so') * handle the convertion failure * load dict in python wrapper sample
jjgod
added a commit
to jjgod/OpenCC
that referenced
this pull request
Nov 12, 2012
I hit this crash on Mac OS X while processing a file with 1 MB in only one line. Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0000000100456000 0x00007fff82eb4337 in memmove$VARIANT$sse3x () (gdb) bt #0 0x00007fff82eb4337 in memmove$VARIANT$sse3x () BYVoid#1 0x00007fff82f2fe97 in fgets () BYVoid#2 0x000000010000135d in convert (input_file=0x1001039a0 "/Users/jjgod/Downloads/昨日的世界/mobi7/z.html", output_file=0x1001000e0 "n.html", config_file=0x1001023f0 "zht2zhs.ini") at /Users/jjgod/Codes/cpp/OpenCC/src/tools/opencc.c:81 BYVoid#3 0x000000010000176e in main (argc=7, argv=0x7fff5fbff920) at /Users/jjgod/Codes/cpp/OpenCC/src/tools/opencc.c:185 The solution I found is to avoid using the fragile fgets() and memory reallocation and replace it with simple fread() and fseek().
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi BYVoid,
你好，我觉得 Python wrapper 有些问题：
__delete__无法保证调用例子如果不加载词典，便无法使用。所以也稍微改了一下。