Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arc rotate auto rotation to rotate to a certain alpha value #12204

Closed
RaananW opened this issue Mar 18, 2022 · 7 comments
Closed

Allow arc rotate auto rotation to rotate to a certain alpha value #12204

RaananW opened this issue Mar 18, 2022 · 7 comments
Assignees
Milestone

Comments

@RaananW
Copy link
Member

RaananW commented Mar 18, 2022

Add an optional target alpha value to the auto rotate behavior. The behavior will stop when reaching this beta value.

@RaananW RaananW added this to the 6.0 milestone Mar 18, 2022
@TheCrowd
Copy link
Contributor

TheCrowd commented Apr 5, 2022

@RaananW could you clarify this issue with more details and can I work on this issue?

@RaananW RaananW changed the title Allow arc rotate auto rotation to rotate to a certain beta value Allow arc rotate auto rotation to rotate to a certain alpha value Apr 5, 2022
@RaananW
Copy link
Member Author

RaananW commented Apr 5, 2022

@TheCrowd - Of course! Thank you :-)

The arc rotate camera has an auto-rotate behavior. the auto rotate behavior rotates constantly until stopped (for example by a mouse input like a click or a drag).

This feature should allow setting a target alpha that will act as a goal for the auto-rotate behavior. the auto-rotate will stop rotating when reaching this alpha value.

(Note that I originally wrote beta, which actually needed to be alpha. corrected all over).

@TheCrowd
Copy link
Contributor

TheCrowd commented Apr 7, 2022

@RaananW Not sure if I understand this correctly, so the goal is achieved, further input won't trigger any rotate behavior?

@RaananW
Copy link
Member Author

RaananW commented Apr 11, 2022

no - if you drag and change the alpha, the alpha should be animated back to the predefined alpha. It's quite straightforward - if alpha is not the predefined alpha (within an epsilon), run the auto-rotate algorithm. If it's === defined alpha, don't rotate until user input was provided.

@TheCrowd
Copy link
Contributor

@RaananW Thanks for explaining, I will have a try

@TheCrowd
Copy link
Contributor

@RaananW please have a look at this PR

deltakosh pushed a commit that referenced this issue Apr 26, 2022
* add target alpha to auto rotate behavior

* code clean

* code refactoring

* import from path
@carolhmj
Copy link
Contributor

Closed by #12429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants